summaryrefslogtreecommitdiff
path: root/sd/CppunitTest_sd_uimpress.mk
diff options
context:
space:
mode:
authorMichael Weghorn <m.weghorn@posteo.de>2019-10-17 14:18:20 +0200
committerMichael Weghorn <m.weghorn@posteo.de>2019-10-17 16:04:19 +0200
commit24004cdf9e2582d429b8987a40eb82af6926013c (patch)
treef564d0d037d95dc3f49f8548a8c19901f83c841d /sd/CppunitTest_sd_uimpress.mk
parent556832332ce2e26ec727d6dffebefe53786f84cd (diff)
gbuild: Treat 'DBUS_GLIB_CFLAGS' as includes, not defines
Since that variable holds the relevant includes, using 'gb_LinkTarget_set_include' makes sure that those flags end up in the correct section, e.g. when generating IDE integration using 'gbuild-to-ide'. E.g. for the 'qtcreator-ide-integraton' make target, this makes sure that they end up in the 'INCLUDES' section in 'sd/sd.pro' and not the 'DEFINES' section, which previously led to an "error: macro name must be an identifier" being shown when editing files underneath 'sd/' in Qt Creator with the Clang Code Model plugin enabled, s.a. commit 4aa60490622cc10f8d3a31489c62a5622d240c83 ("gbuild: treat $({QT,KF}5_CFLAGS) as cxxflags, not defines"). Corresponding entry in my config_host.mk.in on Debian bullseye/testing: export DBUS_GLIB_CFLAGS=$(gb_SPACE)-I/usr/include/glib-2.0 -I/usr/lib/x86_64-linux-gnu/glib-2.0/include Change-Id: I9af9a58fdc05ce6648221c00a20859be777843f9 Reviewed-on: https://gerrit.libreoffice.org/80944 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Diffstat (limited to 'sd/CppunitTest_sd_uimpress.mk')
-rw-r--r--sd/CppunitTest_sd_uimpress.mk3
1 files changed, 2 insertions, 1 deletions
diff --git a/sd/CppunitTest_sd_uimpress.mk b/sd/CppunitTest_sd_uimpress.mk
index 94229cc2c8e3..93426dfc3a55 100644
--- a/sd/CppunitTest_sd_uimpress.mk
+++ b/sd/CppunitTest_sd_uimpress.mk
@@ -80,7 +80,8 @@ $(eval $(call gb_CppunitTest_use_externals,sd_uimpress,\
))
ifneq ($(DBUS_HAVE_GLIB),)
-$(eval $(call gb_CppunitTest_add_defs,sd_uimpress,\
+$(eval $(call gb_CppunitTest_set_include,sd_uimpress,\
+ $$(INCLUDE) \
$(DBUS_GLIB_CFLAGS) \
))
$(eval $(call gb_CppunitTest_add_libs,sd_uimpress,\