ScopedVclPtr vs std::unique_ptr for VclAbstractDialog derivatives

Change-Id: I5e43312b6f42ce0c63946f366eaf1e6dcb9629b2
Reviewed-on: https://gerrit.libreoffice.org/30344
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>

1 files changed, 26 insertions, 0 deletions

diff --git a/sd/inc/sdabstdlg.hxx b/sd/inc/sdabstdlg.hxx
index 51949e8e7f5f..e3269326c3c5 100644
--- a/sd/inc/sdabstdlg.hxx
+++ b/sd/inc/sdabstdlg.hxx
@@ -62,12 +62,16 @@ class SdCustomShowList;
 
 class AbstractCopyDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractCopyDlg() override = default;
 public:
     virtual void    GetAttr( SfxItemSet& rOutAttrs ) = 0;
 };
 
 class AbstractSdCustomShowDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdCustomShowDlg() override = default;
 public:
     virtual bool        IsModified() const = 0;
     virtual bool        IsCustomShow() const = 0;
@@ -75,6 +79,8 @@ public:
 
 class AbstractSdModifyFieldDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdModifyFieldDlg() override = default;
 public:
     virtual SvxFieldData*       GetField() = 0;
     virtual SfxItemSet          GetItemSet() = 0;
@@ -82,6 +88,8 @@ public:
 
 class AbstractSdSnapLineDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdSnapLineDlg() override = default;
 public:
     virtual void GetAttr(SfxItemSet& rOutAttrs) = 0;
     virtual void HideRadioGroup() = 0;
@@ -93,6 +101,8 @@ public:
 
 class AbstractSdInsertLayerDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdInsertLayerDlg() override = default;
 public:
     virtual void    GetAttr( SfxItemSet& rOutAttrs ) = 0;
     //from class vcl::Window
@@ -101,10 +111,14 @@ public:
 
 class AbstractSdInsertPasteDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdInsertPasteDlg() override = default;
 };
 
 class AbstractSdInsertPagesObjsDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdInsertPagesObjsDlg() override = default;
 public:
     virtual std::vector<OUString> GetList ( const sal_uInt16 nType ) = 0;
     virtual bool        IsLink() = 0;
@@ -113,6 +127,8 @@ public:
 
 class AbstractMorphDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractMorphDlg() override = default;
 public:
     virtual void            SaveSettings() const = 0;
     virtual sal_uInt16          GetFadeSteps() const = 0;
@@ -122,30 +138,40 @@ public:
 
 class AbstractSdStartPresDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdStartPresDlg() override = default;
 public:
     virtual void    GetAttr( SfxItemSet& rOutAttrs ) = 0;
 };
 
 class AbstractSdPresLayoutDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdPresLayoutDlg() override = default;
 public:
     virtual void    GetAttr(SfxItemSet& rOutAttrs) = 0;
 };
 
 class AbstractSdVectorizeDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdVectorizeDlg() override = default;
 public:
     virtual const GDIMetaFile&  GetGDIMetaFile() const = 0;
 };
 
 class AbstractSdPublishingDlg : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractSdPublishingDlg() override = default;
 public:
     virtual void GetParameterSequence( css::uno::Sequence< css::beans::PropertyValue >& rParams ) = 0;
 };
 
 class AbstractHeaderFooterDialog : public VclAbstractDialog
 {
+protected:
+    virtual ~AbstractHeaderFooterDialog() override = default;
 };
 
 class SdAbstractDialogFactory