diff options
| author | Justin Luth <jluth@mail.com> | 2025-03-28 14:16:46 -0400 |
|---|---|---|
| committer | Justin Luth <justin.luth@collabora.com> | 2025-03-29 14:31:04 +0100 |
| commit | 210c89a34bda429fe7e0b8f0e63ce5bb5add9d8b (patch) | |
| tree | 6d47c354098409924c6673672b4579485c5f7eb3 /sd/qa/unit/export-tests-ooxml2.cxx | |
| parent | 862483386614347e45ffdde69e109d4d2dd25fd2 (diff) | |
related tdf#165521 oox: ShapeExport::GetNewShapeID of at least 2
This patch fixes an existing bug that was exposed in 7.6.5
by commit bff76421e234df7246a7f49c71a11432f86e09d1.
Microsoft Powerpoint was complaining that my unit test
tdf165521_fixedCellHeight.pptx
needed to be repaired after round-tripping it in LO.
While notesMaster1.xml didn't mind two shapes having the same id=2,
it complained if the first one was set to id=0 or id=1.
However, we can see the same situation in other files
(like slidesMaster1.xml) where there is no complaint,
like in tdf106867.pptx.
So I don't know what really is going on,
but it makes sense to not have overlapping unique IDs,
and thus this patch "just works",
which is enough to make me happy.
Change-Id: I6e7303997bd404e269e71fe156b1390c57ddb349
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/183464
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
Diffstat (limited to 'sd/qa/unit/export-tests-ooxml2.cxx')
| -rw-r--r-- | sd/qa/unit/export-tests-ooxml2.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sd/qa/unit/export-tests-ooxml2.cxx b/sd/qa/unit/export-tests-ooxml2.cxx index d84abbd28e79..8ac9d5aaa94e 100644 --- a/sd/qa/unit/export-tests-ooxml2.cxx +++ b/sd/qa/unit/export-tests-ooxml2.cxx @@ -1316,7 +1316,7 @@ CPPUNIT_TEST_FIXTURE(SdOOXMLExportTest2, testTdf106867) "/p:sld/p:timing/p:tnLst/p:par/p:cTn/p:childTnLst/p:seq/p:cTn/p:childTnLst/p:par/" "p:cTn/p:childTnLst/p:par/p:cTn/p:childTnLst/p:par/p:cTn/p:childTnLst/p:cmd/" "p:cBhvr/p:tgtEl/p:spTgt", - "spid", u"59"); + "spid", u"61"); } CPPUNIT_TEST_FIXTURE(SdOOXMLExportTest2, testTdf112280) |