summaryrefslogtreecommitdiff
path: root/sd/qa
diff options
context:
space:
mode:
authorTünde Tóth <toth.tunde@nisz.hu>2022-02-03 15:13:33 +0100
committerLászló Németh <nemeth@numbertext.org>2022-02-28 14:15:22 +0100
commit259a8e59107bb0a3d4f4f4bb7e056ce1e4231da2 (patch)
tree8190dceb73db2ae9998b1d5a8e8eb6b4196157c9 /sd/qa
parentebf4ba6d4a59b1947a1e5a94c7405693a0960ffa (diff)
tdf#128596 PPTX import: fix default tiled bitmap fill
OOXML bitmap fill element a:blipFill has got default tiled area setting without explicit a:tile in MSO. Previous import of bitmap fill as "BitmapMode_NO_REPEAT" instead of BitmapMode_REPEAT resulted missing or incomplete area fill of shapes and other objects. Change-Id: Idf94f4450980f67172a0126784b3e08cc5c178c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129483 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
Diffstat (limited to 'sd/qa')
-rw-r--r--sd/qa/unit/data/pptx/tdf128596.pptxbin0 -> 29444 bytes
-rw-r--r--sd/qa/unit/import-tests2.cxx17
2 files changed, 17 insertions, 0 deletions
diff --git a/sd/qa/unit/data/pptx/tdf128596.pptx b/sd/qa/unit/data/pptx/tdf128596.pptx
new file mode 100644
index 000000000000..62a166308dc2
--- /dev/null
+++ b/sd/qa/unit/data/pptx/tdf128596.pptx
Binary files differ
diff --git a/sd/qa/unit/import-tests2.cxx b/sd/qa/unit/import-tests2.cxx
index 7c0844e354b9..2654e6f6290e 100644
--- a/sd/qa/unit/import-tests2.cxx
+++ b/sd/qa/unit/import-tests2.cxx
@@ -128,6 +128,7 @@ public:
void testTdf103347();
void testHyperlinksOnShapes();
void testTdf112209();
+ void testTdf128596();
CPPUNIT_TEST_SUITE(SdImportTest2);
@@ -192,6 +193,7 @@ public:
CPPUNIT_TEST(testTdf103347);
CPPUNIT_TEST(testHyperlinksOnShapes);
CPPUNIT_TEST(testTdf112209);
+ CPPUNIT_TEST(testTdf128596);
CPPUNIT_TEST_SUITE_END();
};
@@ -1890,6 +1892,21 @@ void SdImportTest2::testTdf112209()
xDocShRef->DoClose();
}
+void SdImportTest2::testTdf128596()
+{
+ sd::DrawDocShellRef xDocShRef
+ = loadURL(m_directories.getURLFromSrc(u"sd/qa/unit/data/pptx/tdf128596.pptx"), PPTX);
+ uno::Reference<beans::XPropertySet> xShape(getShapeFromPage(0, 0, xDocShRef),
+ uno::UNO_SET_THROW);
+ CPPUNIT_ASSERT(xShape.is());
+
+ css::drawing::BitmapMode bitmapmode;
+ xShape->getPropertyValue("FillBitmapMode") >>= bitmapmode;
+ CPPUNIT_ASSERT_EQUAL(css::drawing::BitmapMode_REPEAT, bitmapmode);
+
+ xDocShRef->DoClose();
+}
+
CPPUNIT_TEST_SUITE_REGISTRATION(SdImportTest2);
CPPUNIT_PLUGIN_IMPLEMENT();