diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-21 13:07:10 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-23 10:41:38 +0100 |
| commit | 91b4e4531621b7afb2dbab1a8aa62c92da66951a (patch) | |
| tree | f36ee2468313a4000e310b4db4903c96e747a03e /sd/source/ui/animations | |
| parent | ea20bc176cbf575e39c602a91dd3e6919b3fc31e (diff) | |
new loplugin: pointerbool
look for possibly bogus implicit conversions to bool when passing
(normally pointer) args to bool params.
this plugin comes in the wake of a couple of bugs caused by refactoring,
where some of the call sites were not currently updated.
Of the changes, the following are real bugs:
desktop/../dp_persmap.cxx
StartInputFieldDlg
in sw/../fldmgr.cxx
which occurred as a result of
commit 39d719a80d8c87856c84e3ecd569d45fa6f8a30e
Date: Tue May 3 11:39:37 2016 +0200
tdf#99529 sw: don't pop up input field dialog before inserting field
CSerializationURLEncoded::encode_and_append in
forms/../serialization_urlencoded.cxx
XclExpCFImpl::XclExpCFImpl
in sc/../xecontent.cxx
I have no idea how to properly fix this, just made a guess.
SwDocTest::test64kPageDescs
in sw/qa/core/uwriter.cxx
which looks like a simple copy/paste error.
Change-Id: I795ebd5ef485a1d36863dc27fe13832989f5a441
Reviewed-on: https://gerrit.libreoffice.org/48291
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd/source/ui/animations')
| -rw-r--r-- | sd/source/ui/animations/CustomAnimationPane.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sd/source/ui/animations/CustomAnimationPane.cxx b/sd/source/ui/animations/CustomAnimationPane.cxx index 17ed3f4b0b36..8ebd2f1ee3e6 100644 --- a/sd/source/ui/animations/CustomAnimationPane.cxx +++ b/sd/source/ui/animations/CustomAnimationPane.cxx @@ -525,7 +525,7 @@ void CustomAnimationPane::updateControls() const int nSelectionCount = maListSelection.size(); mpPBAddEffect->Enable( maViewSelection.hasValue() ); - mpPBRemoveEffect->Enable(nSelectionCount); + mpPBRemoveEffect->Enable(nSelectionCount != 0); bool bIsSelected = (nSelectionCount == 1); if(bIsSelected) |