diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2017-02-10 09:24:16 +0000 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2017-06-06 14:15:43 +0200 |
| commit | d0069e5189f5410e1db7aa395f0754109e872f46 (patch) | |
| tree | 30c860e8d780c3461c6048be9594f642f03de5de /sd/source/ui/inc | |
| parent | cc2db25645ede743bdc3824fe7d26ea4beda6a96 (diff) | |
add COVERITY_NOEXCEPT_FALSE
to markup dtors that coverity warns might throw exceptions
which won't throw in practice, or where std::terminate is
an acceptable response if they do
Change-Id: I32b94814e8245372e1d1dc36be0d81e3564042f4
Reviewed-on: https://gerrit.libreoffice.org/38318
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sd/source/ui/inc')
| -rw-r--r-- | sd/source/ui/inc/OutlineView.hxx | 2 | ||||
| -rw-r--r-- | sd/source/ui/inc/ToolBarManager.hxx | 2 | ||||
| -rw-r--r-- | sd/source/ui/inc/ViewShellManager.hxx | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/sd/source/ui/inc/OutlineView.hxx b/sd/source/ui/inc/OutlineView.hxx index 7bbd68a47510..552bfa041595 100644 --- a/sd/source/ui/inc/OutlineView.hxx +++ b/sd/source/ui/inc/OutlineView.hxx @@ -228,7 +228,7 @@ class OutlineViewModelChangeGuard { public: OutlineViewModelChangeGuard( OutlineView& rView ); - ~OutlineViewModelChangeGuard(); + ~OutlineViewModelChangeGuard() COVERITY_NOEXCEPT_FALSE; private: OutlineView& mrView; }; diff --git a/sd/source/ui/inc/ToolBarManager.hxx b/sd/source/ui/inc/ToolBarManager.hxx index 1fb29620d4ac..782f23f006e7 100644 --- a/sd/source/ui/inc/ToolBarManager.hxx +++ b/sd/source/ui/inc/ToolBarManager.hxx @@ -240,7 +240,7 @@ public: class UpdateLock { public: UpdateLock(const std::shared_ptr<ToolBarManager>& rpManager) : mpManager(rpManager) { mpManager->LockUpdate(); } - ~UpdateLock() { mpManager->UnlockUpdate(); } + ~UpdateLock() COVERITY_NOEXCEPT_FALSE { mpManager->UnlockUpdate(); } private: std::shared_ptr<ToolBarManager> mpManager; }; diff --git a/sd/source/ui/inc/ViewShellManager.hxx b/sd/source/ui/inc/ViewShellManager.hxx index 7ffb1e352652..da6fadb944b7 100644 --- a/sd/source/ui/inc/ViewShellManager.hxx +++ b/sd/source/ui/inc/ViewShellManager.hxx @@ -174,7 +174,7 @@ public: public: UpdateLock (const std::shared_ptr<ViewShellManager>& rpManager) : mpManager(rpManager) {mpManager->LockUpdate();} - ~UpdateLock() {mpManager->UnlockUpdate();}; + ~UpdateLock() COVERITY_NOEXCEPT_FALSE {mpManager->UnlockUpdate();} private: std::shared_ptr<ViewShellManager> mpManager; }; |