diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-03-06 14:40:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-03-09 11:33:43 +0100 |
| commit | abe39f7781f59b96c5a8d3dd5b41c60fdf04ad84 (patch) | |
| tree | 0f72d1968e5f25e3f280688a414398e3f4a7cce8 /sd/source/ui/slideshow | |
| parent | bdb1c72198f60fdd91460e26282134d43bc0e2df (diff) | |
improve loplugin:unusedfields
noticed something that wasn't being picked up, wrote some tests,
and found an unhandled case in Plugin::getParentFunctionDecl
Change-Id: I52b4ea273be6614e197392dfc4d6053bbc1704de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90141
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd/source/ui/slideshow')
| -rw-r--r-- | sd/source/ui/slideshow/PaneHider.cxx | 5 | ||||
| -rw-r--r-- | sd/source/ui/slideshow/PaneHider.hxx | 1 |
2 files changed, 2 insertions, 4 deletions
diff --git a/sd/source/ui/slideshow/PaneHider.cxx b/sd/source/ui/slideshow/PaneHider.cxx index 98b260c8f774..079633271e89 100644 --- a/sd/source/ui/slideshow/PaneHider.cxx +++ b/sd/source/ui/slideshow/PaneHider.cxx @@ -39,7 +39,6 @@ using ::com::sun::star::lang::DisposedException; namespace sd { PaneHider::PaneHider (const ViewShell& rViewShell, SlideshowImpl* pSlideShow) - : mrViewShell(rViewShell) { // Hide the left and right pane windows when a slideshow exists and is // not full screen. @@ -49,7 +48,7 @@ PaneHider::PaneHider (const ViewShell& rViewShell, SlideshowImpl* pSlideShow) try { Reference<XControllerManager> xControllerManager ( - mrViewShell.GetViewShellBase().GetController(), UNO_QUERY_THROW); + rViewShell.GetViewShellBase().GetController(), UNO_QUERY_THROW); mxConfigurationController = xControllerManager->getConfigurationController(); if (mxConfigurationController.is()) { @@ -72,7 +71,7 @@ PaneHider::PaneHider (const ViewShell& rViewShell, SlideshowImpl* pSlideShow) } } } - FrameworkHelper::Instance(mrViewShell.GetViewShellBase())->WaitForUpdate(); + FrameworkHelper::Instance(rViewShell.GetViewShellBase())->WaitForUpdate(); } catch (RuntimeException&) { diff --git a/sd/source/ui/slideshow/PaneHider.hxx b/sd/source/ui/slideshow/PaneHider.hxx index 9063f0e61a8e..44ba3eee7f68 100644 --- a/sd/source/ui/slideshow/PaneHider.hxx +++ b/sd/source/ui/slideshow/PaneHider.hxx @@ -47,7 +47,6 @@ public: ~PaneHider(); private: - const ViewShell& mrViewShell; /** Remember whether the visibility states of the windows of the panes has been modified and have to be restored. */ |