clang-tidy:readability-redundant-member-init

Change-Id: I0a9b238c0ba551b330bee7b89eb6cd48fad1b265
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/121488
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

10 files changed, 6 insertions, 52 deletions

diff --git a/sd/source/ui/view/DocumentRenderer.cxx b/sd/source/ui/view/DocumentRenderer.cxx
index 2aa37302eb03..38989bd61c2a 100644
--- a/sd/source/ui/view/DocumentRenderer.cxx
+++ b/sd/source/ui/view/DocumentRenderer.cxx
@@ -272,12 +272,9 @@ namespace {
             const bool bPrintMarkedOnly)
             : mpPrinter(pPrinter),
               mnDrawMode(DrawModeFlags::Default),
-              msTimeDate(),
-              msPageString(),
               maPrintSize(0,0),
               maPageSize(0,0),
               meOrientation(Orientation::Portrait),
-              maMap(),
               mbPrintMarkedOnly(bPrintMarkedOnly)
         {}
 
@@ -1164,9 +1161,6 @@ public:
         , mrBase(rBase)
         , mbIsDisposed(false)
         , mpPrinter(nullptr)
-        , mpOptions()
-        , maPrinterPages()
-        , mpPrintView()
         , mbHasOrientationWarningBeenShown(false)
     {
         DialogCreator aCreator( mrBase, mrBase.GetDocShell()->GetDocumentType() == DocumentType::Impress, GetCurrentPageIndex() );
diff --git a/sd/source/ui/view/FormShellManager.cxx b/sd/source/ui/view/FormShellManager.cxx
index c9126714cc24..3efa9bed71bb 100644
--- a/sd/source/ui/view/FormShellManager.cxx
+++ b/sd/source/ui/view/FormShellManager.cxx
@@ -53,7 +53,6 @@ FormShellManager::FormShellManager (ViewShellBase& rBase)
     : mrBase(rBase),
       mpFormShell(nullptr),
       mbFormShellAboveViewShell(false),
-      mpSubShellFactory(),
       mbIsMainViewChangePending(false),
       mpMainViewShellWindow(nullptr)
 {
diff --git a/sd/source/ui/view/Outliner.cxx b/sd/source/ui/view/Outliner.cxx
index 316e330a7bed..16e86f239d83 100644
--- a/sd/source/ui/view/Outliner.cxx
+++ b/sd/source/ui/view/Outliner.cxx
@@ -134,7 +134,6 @@ SdOutliner::SdOutliner( SdDrawDocument* pDoc, OutlinerMode nMode )
       mpImpl(new Implementation()),
       meMode(SEARCH),
       mpView(nullptr),
-      mpWeakViewShell(),
       mpWindow(nullptr),
       mpDrawDocument(pDoc),
       mnConversionLanguage(LANGUAGE_NONE),
@@ -146,7 +145,6 @@ SdOutliner::SdOutliner( SdDrawDocument* pDoc, OutlinerMode nMode )
       mbFoundObject(false),
       mbDirectionIsForward(true),
       mbRestrictSearchToSelection(false),
-      maMarkListCopy(),
       mpObj(nullptr),
       mpFirstObj(nullptr),
       mpSearchSpellTextObj(nullptr),
@@ -156,12 +154,7 @@ SdOutliner::SdOutliner( SdDrawDocument* pDoc, OutlinerMode nMode )
       meStartEditMode(EditMode::Page),
       mnStartPageIndex(sal_uInt16(-1)),
       mpStartEditedObject(nullptr),
-      maStartSelection(),
       mpSearchItem(nullptr),
-      maObjectIterator(),
-      maCurrentPosition(),
-      maSearchStartPosition(),
-      maLastValidPosition(),
       mbPrepareSpellingPending(true)
 {
     SetStyleSheetPool(static_cast<SfxStyleSheetPool*>( mpDrawDocument->GetStyleSheetPool() ));
diff --git a/sd/source/ui/view/OutlinerIterator.cxx b/sd/source/ui/view/OutlinerIterator.cxx
index e839e71b9ba4..8cdb29330e6e 100644
--- a/sd/source/ui/view/OutlinerIterator.cxx
+++ b/sd/source/ui/view/OutlinerIterator.cxx
@@ -338,8 +338,7 @@ sal_Int32 OutlinerContainer::GetPageIndex (
 IteratorImplBase::IteratorImplBase(SdDrawDocument* pDocument,
     const std::weak_ptr<ViewShell>& rpViewShellWeak,
     bool bDirectionIsForward)
-:   maPosition()
-,   mpDocument (pDocument)
+:   mpDocument (pDocument)
 ,   mpViewShellWeak (rpViewShellWeak)
 ,   mbDirectionIsForward (bDirectionIsForward)
 {
@@ -362,8 +361,7 @@ IteratorImplBase::IteratorImplBase(SdDrawDocument* pDocument,
 IteratorImplBase::IteratorImplBase( SdDrawDocument* pDocument,
     const std::weak_ptr<ViewShell>& rpViewShellWeak,
     bool bDirectionIsForward, PageKind ePageKind, EditMode eEditMode)
-: maPosition()
-, mpDocument (pDocument)
+: mpDocument (pDocument)
 , mpViewShellWeak (rpViewShellWeak)
 , mbDirectionIsForward (bDirectionIsForward)
 {
diff --git a/sd/source/ui/view/ToolBarManager.cxx b/sd/source/ui/view/ToolBarManager.cxx
index 78dc658584df..0bb0f9528cb1 100644
--- a/sd/source/ui/view/ToolBarManager.cxx
+++ b/sd/source/ui/view/ToolBarManager.cxx
@@ -342,7 +342,6 @@ std::shared_ptr<ToolBarManager> ToolBarManager::Create (
 }
 
 ToolBarManager::ToolBarManager()
-        : mpImpl()
 {
 }
 
@@ -500,18 +499,12 @@ ToolBarManager::Implementation::Implementation (
     const std::shared_ptr<sd::tools::EventMultiplexer>& rpMultiplexer,
     const std::shared_ptr<ViewShellManager>& rpViewShellManager,
     const std::shared_ptr<ToolBarManager>& rpToolBarManager)
-    : maMutex(),
-      mrBase(rBase),
+    : mrBase(rBase),
       mpEventMultiplexer(rpMultiplexer),
       mbIsValid(false),
-      maToolBarList(),
-      maToolBarShellList(),
       mnLockCount(0),
       mbPreUpdatePending(false),
       mbPostUpdatePending(false),
-      mpSynchronousLayouterLock(),
-      mpAsynchronousLayouterLock(),
-      mpViewShellManagerLock(),
       mnPendingUpdateCall(nullptr),
       mnPendingSetValidCall(nullptr),
       maToolBarRules(rpToolBarManager,rpViewShellManager)
@@ -1176,8 +1169,6 @@ void ToolBarRules::SubShellRemoved (
 //===== ToolBarList ===========================================================
 
 ToolBarList::ToolBarList()
-    : maGroups(),
-      maActiveToolBars()
 {
 }
 
@@ -1294,8 +1285,6 @@ ToolBarShellList::ShellDescriptor::ShellDescriptor (
 }
 
 ToolBarShellList::ToolBarShellList()
-: maNewList()
-, maCurrentList()
 {
 }
 
diff --git a/sd/source/ui/view/ViewShellBase.cxx b/sd/source/ui/view/ViewShellBase.cxx
index d4067944f802..897aed6f1524 100644
--- a/sd/source/ui/view/ViewShellBase.cxx
+++ b/sd/source/ui/view/ViewShellBase.cxx
@@ -223,7 +223,6 @@ ViewShellBase::ViewShellBase (
     SfxViewFrame* _pFrame,
     SfxViewShell*)
     : SfxViewShell (_pFrame, SfxViewShellFlags::HAS_PRINTOPTIONS),
-      mpImpl(),
       mpDocShell (nullptr),
       mpDocument (nullptr)
 {
@@ -1024,15 +1023,7 @@ void ViewShellBase::NotifyCursor(SfxViewShell* pOtherShell) const
 //===== ViewShellBase::Implementation =========================================
 
 ViewShellBase::Implementation::Implementation (ViewShellBase& rBase)
-    : mpController(),
-      mpViewTabBar(),
-      maClientArea(),
-      mbIsClosing(false),
-      mpViewWindow(),
-      mpToolBarManager(),
-      mpViewShellManager(),
-      mpEventMultiplexer(),
-      mpFormShellManager(),
+    : mbIsClosing(false),
       mrBase(rBase),
       mbUserWantsTabBar(false),
       mbTabBarShouldBeVisible(true),
diff --git a/sd/source/ui/view/ViewShellHint.cxx b/sd/source/ui/view/ViewShellHint.cxx
index 6605ee9232c2..b86cbaa325d7 100644
--- a/sd/source/ui/view/ViewShellHint.cxx
+++ b/sd/source/ui/view/ViewShellHint.cxx
@@ -22,8 +22,7 @@
 namespace sd
 {
 ViewShellHint::ViewShellHint(HintId eHintId)
-    : SfxHint()
-    , meHintId(eHintId)
+    : meHintId(eHintId)
 {
 }
 
diff --git a/sd/source/ui/view/ViewShellImplementation.cxx b/sd/source/ui/view/ViewShellImplementation.cxx
index 4ca73b2bb5dc..3f301c2efcd1 100644
--- a/sd/source/ui/view/ViewShellImplementation.cxx
+++ b/sd/source/ui/view/ViewShellImplementation.cxx
@@ -59,8 +59,6 @@ ViewShell::Implementation::Implementation (ViewShell& rViewShell)
     : mbIsMainViewShell(false),
       mbIsInitialized(false),
       mbArrangeActive(false),
-      mpSubShellFactory(),
-      mpUpdateLockForMouse(),
       mrViewShell(rViewShell)
 {
 }
@@ -333,8 +331,7 @@ std::shared_ptr<ViewShell::Implementation::ToolBarManagerLock>
 
 ViewShell::Implementation::ToolBarManagerLock::ToolBarManagerLock (
     const std::shared_ptr<ToolBarManager>& rpManager)
-    : mpLock(new ToolBarManager::UpdateLock(rpManager)),
-      maTimer()
+    : mpLock(new ToolBarManager::UpdateLock(rpManager))
 {
     // Start a timer that will unlock the ToolBarManager update lock when
     // that is not done explicitly by calling Release().
diff --git a/sd/source/ui/view/ViewShellManager.cxx b/sd/source/ui/view/ViewShellManager.cxx
index 7f4039a0fc5d..db2ee5f8f158 100644
--- a/sd/source/ui/view/ViewShellManager.cxx
+++ b/sd/source/ui/view/ViewShellManager.cxx
@@ -353,9 +353,6 @@ void ViewShellManager::UnlockUpdate()
 ViewShellManager::Implementation::Implementation (
     ViewShellBase& rBase)
     : mrBase(rBase),
-      maMutex(),
-      maShellFactories(),
-      maActiveViewShells(),
       mnUpdateLockCount(0),
       mbShellStackIsUpToDate(true),
       mpFormShell(nullptr),
@@ -1143,7 +1140,6 @@ namespace {
 ShellDescriptor::ShellDescriptor()
     : mpShell(nullptr),
       mnId(ToolbarId::None),
-      mpFactory(),
       mbIsListenerAddedToWindow(false)
 {
 }
@@ -1152,7 +1148,6 @@ ShellDescriptor::ShellDescriptor (
     ShellId nId)
     : mpShell(nullptr),
       mnId(nId),
-      mpFactory(),
       mbIsListenerAddedToWindow(false)
 {
 }
diff --git a/sd/source/ui/view/ViewTabBar.cxx b/sd/source/ui/view/ViewTabBar.cxx
index cd09d77d479a..3760d34dcc5c 100644
--- a/sd/source/ui/view/ViewTabBar.cxx
+++ b/sd/source/ui/view/ViewTabBar.cxx
@@ -61,7 +61,6 @@ ViewTabBar::ViewTabBar (
     : ViewTabBarInterfaceBase(maMutex),
       mpTabControl(VclPtr<TabBarControl>::Create(GetAnchorWindow(rxViewTabBarId,rxController), this)),
       mxController(rxController),
-      maTabBarButtons(),
       mxViewTabBarId(rxViewTabBarId),
       mpViewShellBase(nullptr),
       mnNoteBookWidthPadding(0)