diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-13 14:29:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-17 09:57:35 +0100 |
| commit | 8ef6067596cf4b2c52fbce94b44bf7af9fefa643 (patch) | |
| tree | f4cca1a99ba97683b14fa6fe0f1f45f75bf855c2 /sd/source/ui | |
| parent | 75bada928cf08d2afc6efe52ba99b45088bc9eec (diff) | |
loplugin:stringviewparam check methods too
not just functions
Change-Id: Icca295dd159002b428b73f2c95d40725434f04d9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105789
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd/source/ui')
| -rw-r--r-- | sd/source/ui/animations/CustomAnimationDialog.cxx | 4 | ||||
| -rw-r--r-- | sd/source/ui/view/sdview4.cxx | 2 |
2 files changed, 3 insertions, 3 deletions
diff --git a/sd/source/ui/animations/CustomAnimationDialog.cxx b/sd/source/ui/animations/CustomAnimationDialog.cxx index 5110587f4245..67e0e0cc66b1 100644 --- a/sd/source/ui/animations/CustomAnimationDialog.cxx +++ b/sd/source/ui/animations/CustomAnimationDialog.cxx @@ -863,7 +863,7 @@ private: void updateControlStates(); void fillSoundListBox(); void clearSoundListBox(); - sal_Int32 getSoundObject( const OUString& rStr ); + sal_Int32 getSoundObject( std::u16string_view rStr ); void openSoundFileDialog(); void onSoundPreview(); weld::Window* GetFrameWeld() const { return mpDialog; } @@ -1317,7 +1317,7 @@ void CustomAnimationEffectTabPage::clearSoundListBox() mxLBSound->clear(); } -sal_Int32 CustomAnimationEffectTabPage::getSoundObject( const OUString& rStr ) +sal_Int32 CustomAnimationEffectTabPage::getSoundObject( std::u16string_view rStr ) { size_t i; const size_t nCount = maSoundList.size(); diff --git a/sd/source/ui/view/sdview4.cxx b/sd/source/ui/view/sdview4.cxx index 59aa0c396858..c1305607db13 100644 --- a/sd/source/ui/view/sdview4.cxx +++ b/sd/source/ui/view/sdview4.cxx @@ -427,7 +427,7 @@ IMPL_LINK_NOARG(View, DropInsertFileHdl, Timer *, void) SdrGrafObj* pGrafObj = InsertGraphic( aGraphic, nTempAction, maDropPos, nullptr, nullptr ); if(pGrafObj && bLink) { - pGrafObj->SetGraphicLink( aCurrentDropFile, ""/*TODO?*/, OUString() ); + pGrafObj->SetGraphicLink( aCurrentDropFile, u""/*TODO?*/, OUString() ); } // return action from first inserted graphic |