diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-01-28 15:17:04 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-01-29 18:59:53 +0100 |
commit | c3d5c9a08df77f9c0d0fd2493cf299dbad1a9dff (patch) | |
tree | f448517b6031741ab182685f3cf8ee332deac2f4 /sd/source | |
parent | 58c849a94234f18eac020be66117aa2378487e2f (diff) |
used TypedWhichId in the constructor of various svx *Item classes
to act as an extra check that we have the association of Item and
TypedWhichId annotations correct.
(*) requires that I add an upcasting constructor to TypedWhichId
(*) Make the field dialog stuff in writer use a new item id
FN_FIELD_DIALOG_DOC_PROPS instead of abusing the
existing SID_DOCINFO
Change-Id: Ica4aea930c80124609a063768c9af5a189df1c27
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129098
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd/source')
-rw-r--r-- | sd/source/ui/dlg/paragr.cxx | 1 | ||||
-rw-r--r-- | sd/source/ui/view/drviews3.cxx | 8 | ||||
-rw-r--r-- | sd/source/ui/view/drviewsf.cxx | 1 |
3 files changed, 6 insertions, 4 deletions
diff --git a/sd/source/ui/dlg/paragr.cxx b/sd/source/ui/dlg/paragr.cxx index 2918fbb22c77..cead5dfc4634 100644 --- a/sd/source/ui/dlg/paragr.cxx +++ b/sd/source/ui/dlg/paragr.cxx @@ -24,6 +24,7 @@ #include <svx/dialogs.hrc> #include <svx/svxids.hrc> #include <svx/flagsdef.hxx> +#include <svx/xcolit.hxx> #include <paragr.hxx> #include <sdattr.hrc> diff --git a/sd/source/ui/view/drviews3.cxx b/sd/source/ui/view/drviews3.cxx index bddb47947e88..19eea777637e 100644 --- a/sd/source/ui/view/drviews3.cxx +++ b/sd/source/ui/view/drviews3.cxx @@ -556,8 +556,8 @@ void DrawViewShell::ExecRuler(SfxRequest& rReq) std::unique_ptr<SdUndoGroup> pUndoGroup(new SdUndoGroup(GetDoc())); pUndoGroup->SetComment(SdResId(STR_UNDO_CHANGE_PAGEBORDER)); - const SvxLongLRSpaceItem& rLRSpace = static_cast<const SvxLongLRSpaceItem&>( - pArgs->Get(SID_ATTR_LONG_LRSPACE)); + const SvxLongLRSpaceItem& rLRSpace = + pArgs->Get(SID_ATTR_LONG_LRSPACE); if( mpDrawView->IsTextEdit() ) { @@ -621,8 +621,8 @@ void DrawViewShell::ExecRuler(SfxRequest& rReq) std::unique_ptr<SdUndoGroup> pUndoGroup(new SdUndoGroup(GetDoc())); pUndoGroup->SetComment(SdResId(STR_UNDO_CHANGE_PAGEBORDER)); - const SvxLongULSpaceItem& rULSpace = static_cast<const SvxLongULSpaceItem&>( - pArgs->Get(SID_ATTR_LONG_ULSPACE)); + const SvxLongULSpaceItem& rULSpace = + pArgs->Get(SID_ATTR_LONG_ULSPACE); if( mpDrawView->IsTextEdit() ) { diff --git a/sd/source/ui/view/drviewsf.cxx b/sd/source/ui/view/drviewsf.cxx index 4c1eae173391..d54b43fd908a 100644 --- a/sd/source/ui/view/drviewsf.cxx +++ b/sd/source/ui/view/drviewsf.cxx @@ -22,6 +22,7 @@ #include <com/sun/star/beans/XPropertySet.hpp> #include <comphelper/string.hxx> #include <svx/svxids.hrc> +#include <svx/sdmetitm.hxx> #include <svx/hlnkitem.hxx> #include <editeng/eeitem.hxx> #include <editeng/flditem.hxx> |