diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-16 08:59:52 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-16 09:10:16 +0000 |
commit | 7cca2c7fb328e64f1779993b60809eff6974b970 (patch) | |
tree | 1e9463b671572a0ea0d04f443033b9eaf8933bcc /sd | |
parent | 3c73942c8c4b97ee9ede65890e1b1db3cac753c5 (diff) |
new loplugin finalprotected
look for final classes, and make sure they don't have protected members
Change-Id: I1fa810659bba02b61a5160dbfd8e24185ec9abf4
Reviewed-on: https://gerrit.libreoffice.org/30895
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
-rw-r--r-- | sd/inc/CustomAnimationEffect.hxx | 3 | ||||
-rw-r--r-- | sd/source/ui/inc/SlideSorter.hxx | 3 |
2 files changed, 2 insertions, 4 deletions
diff --git a/sd/inc/CustomAnimationEffect.hxx b/sd/inc/CustomAnimationEffect.hxx index 952582b8706b..f9391a4b50cb 100644 --- a/sd/inc/CustomAnimationEffect.hxx +++ b/sd/inc/CustomAnimationEffect.hxx @@ -169,10 +169,9 @@ public: SAL_DLLPRIVATE void updateSdrPathObjFromPath( SdrPathObj& rPathObj ); SAL_DLLPRIVATE void updatePathFromSdrPathObj( const SdrPathObj& rPathObj ); -protected: +private: SAL_DLLPRIVATE void setEffectSequence( EffectSequenceHelper* pSequence ) { mpEffectSequence = pSequence; } -private: sal_Int16 mnNodeType; OUString maPresetId; OUString maPresetSubType; diff --git a/sd/source/ui/inc/SlideSorter.hxx b/sd/source/ui/inc/SlideSorter.hxx index 684f4dbac1a2..0c7dd9554861 100644 --- a/sd/source/ui/inc/SlideSorter.hxx +++ b/sd/source/ui/inc/SlideSorter.hxx @@ -187,7 +187,7 @@ public: */ std::shared_ptr<view::Theme> const & GetTheme() const; -protected: +private: /** This virtual method makes it possible to create a specialization of the slide sorter view shell that works with its own implementation of model, view, and controller. The default implementation simply @@ -208,7 +208,6 @@ protected: */ controller::SlideSorterController* CreateController(); -private: bool mbIsValid; std::unique_ptr<controller::SlideSorterController> mpSlideSorterController; |