diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-18 14:15:59 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2019-09-19 11:42:47 +0200 |
| commit | 82572caae4a282cdf79456b977508ca71507c584 (patch) | |
| tree | befc8478f8cd9bf7e7c9a87a776b063a9ed4b718 /sd | |
| parent | 71ef762f21ada8c25aad2183065478171e985e8c (diff) | |
improve and enable loplugin:fragiledestructor
Where the problem was benign and the class was not extended, I marked
the class as final.
Where the problem was benign and the class was extended, I marked the
relevant callee methods as final.
Other cases were excluded in the plugin.
Change-Id: Idb762fb2206af4e8b534aa35ff77f8368c7909bc
Reviewed-on: https://gerrit.libreoffice.org/79089
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/source/ui/inc/sdxfer.hxx | 2 | ||||
| -rw-r--r-- | sd/source/ui/slideshow/slideshowimpl.hxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/sd/source/ui/inc/sdxfer.hxx b/sd/source/ui/inc/sdxfer.hxx index cd9fca61c58f..bebbcd2c7c11 100644 --- a/sd/source/ui/inc/sdxfer.hxx +++ b/sd/source/ui/inc/sdxfer.hxx @@ -107,7 +107,7 @@ protected: virtual void AddSupportedFormats() override; virtual bool GetData( const css::datatransfer::DataFlavor& rFlavor, const OUString& rDestDoc ) override; virtual bool WriteObject( tools::SvRef<SotStorageStream>& rxOStm, void* pUserObject, sal_uInt32 nUserObjectId, const css::datatransfer::DataFlavor& rFlavor ) override; - virtual void ObjectReleased() override; + virtual void ObjectReleased() override final; virtual sal_Int64 SAL_CALL getSomething( const css::uno::Sequence< sal_Int8 >& rId ) override; diff --git a/sd/source/ui/slideshow/slideshowimpl.hxx b/sd/source/ui/slideshow/slideshowimpl.hxx index 80cab80c199b..a696064c6836 100644 --- a/sd/source/ui/slideshow/slideshowimpl.hxx +++ b/sd/source/ui/slideshow/slideshowimpl.hxx @@ -127,7 +127,7 @@ private: typedef ::cppu::WeakComponentImplHelper< css::presentation::XSlideShowController, css::container::XIndexAccess > SlideshowImplBase; -class SlideshowImpl : private ::cppu::BaseMutex, public SlideshowImplBase +class SlideshowImpl final : private ::cppu::BaseMutex, public SlideshowImplBase { friend class SlideShow; friend class SlideShowView; |