coverity#704766 Dereference after null check

Change-Id: I8491260f198e80138241de891ef29cc8ab21a008

1 files changed, 8 insertions, 11 deletions

diff --git a/sd/source/ui/slidesorter/controller/SlsTransferableData.cxx b/sd/source/ui/slidesorter/controller/SlsTransferableData.cxx
index baa5c3b3531c..485198965534 100644
--- a/sd/source/ui/slidesorter/controller/SlsTransferableData.cxx
+++ b/sd/source/ui/slidesorter/controller/SlsTransferableData.cxx
@@ -38,24 +38,21 @@ SdTransferable* TransferableData::CreateTransferable (
     return pTransferable;
 }
 
-
-
-
 ::boost::shared_ptr<TransferableData> TransferableData::GetFromTransferable (const SdTransferable* pTransferable)
 {
-    ::boost::shared_ptr<TransferableData> pData;
-    for (sal_Int32 nIndex=0,nCount=pTransferable->GetUserDataCount(); nIndex<nCount; ++nIndex)
+    if (pTransferable)
     {
-        pData = ::boost::dynamic_pointer_cast<TransferableData>(pTransferable->GetUserData(nIndex));
-        if (pData)
-            return pData;
+        for (sal_Int32 nIndex=0,nCount=pTransferable->GetUserDataCount(); nIndex<nCount; ++nIndex)
+        {
+            ::boost::shared_ptr<TransferableData> xData =
+                ::boost::dynamic_pointer_cast<TransferableData>(pTransferable->GetUserData(nIndex));
+            if (xData)
+                return xData;
+        }
     }
     return ::boost::shared_ptr<TransferableData>();
 }
 
-
-
-
 TransferableData::TransferableData (
     SlideSorterViewShell* pViewShell,
     const ::std::vector<Representative>& rRepresentatives)