summaryrefslogtreecommitdiff
path: root/sd
diff options
context:
space:
mode:
authorCaolán McNamara <caolanm@redhat.com>2022-09-01 11:28:31 +0100
committerCaolán McNamara <caolanm@redhat.com>2022-09-01 15:01:20 +0200
commitf5ce2df24a91796d6b8c732ad1a8ab3c5f736cde (patch)
tree4fff2b5ec165bbb0a89780c30422c61f7c7b550f /sd
parent526c7c72fad67a50e4bc14b7484cd4043387ca52 (diff)
cid#1500537 silence Dereference after null check
CreateView never return a null/empty Change-Id: I55829aff18f6ea3d508cfbd101ebcbf09ff37295 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sd')
-rw-r--r--sd/source/ui/framework/factories/BasicViewFactory.cxx3
1 files changed, 1 insertions, 2 deletions
diff --git a/sd/source/ui/framework/factories/BasicViewFactory.cxx b/sd/source/ui/framework/factories/BasicViewFactory.cxx
index 425cb44467f8..5e862c6aebc2 100644
--- a/sd/source/ui/framework/factories/BasicViewFactory.cxx
+++ b/sd/source/ui/framework/factories/BasicViewFactory.cxx
@@ -163,8 +163,7 @@ Reference<XResource> SAL_CALL BasicViewFactory::createResource (
pDescriptor = CreateView(rxViewId, *pFrame, *pWindow, xPane, pFrameView, bIsCenterPane);
}
- if (pDescriptor != nullptr)
- xView = pDescriptor->mxView;
+ xView = pDescriptor->mxView;
mpViewShellContainer->push_back(pDescriptor);