diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2016-08-18 12:27:49 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2016-08-18 14:24:11 +0100 |
| commit | 4630157e29f565c110f4fa11223a2d2358508c26 (patch) | |
| tree | f27b9b6e953ec3ae433172229a596ab0bdc9d934 /sd | |
| parent | 8a6eb111609fbb1e0270ef5ba475b027635c9749 (diff) | |
cppcheck: passedByValue
Change-Id: I3ffcfe1294a1cbb06aadd3a1a79e9259876e38cc
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/source/ui/animations/CustomAnimationList.cxx | 8 | ||||
| -rw-r--r-- | sd/source/ui/dlg/RemoteDialogClientBox.cxx | 6 | ||||
| -rw-r--r-- | sd/source/ui/dlg/RemoteDialogClientBox.hxx | 2 |
3 files changed, 8 insertions, 8 deletions
diff --git a/sd/source/ui/animations/CustomAnimationList.cxx b/sd/source/ui/animations/CustomAnimationList.cxx index ca08e350fc9a..d14f670702d2 100644 --- a/sd/source/ui/animations/CustomAnimationList.cxx +++ b/sd/source/ui/animations/CustomAnimationList.cxx @@ -202,7 +202,7 @@ class CustomAnimationListEntryItem : public SvLBoxString { public: CustomAnimationListEntryItem(const OUString& aDescription, - CustomAnimationEffectPtr pEffect, CustomAnimationList* pParent); + const CustomAnimationEffectPtr& pEffect, CustomAnimationList* pParent); virtual ~CustomAnimationListEntryItem(); void InitViewData(SvTreeListBox*,SvTreeListEntry*,SvViewDataItem* = nullptr) override; SvLBoxItem* Create() const override; @@ -220,7 +220,7 @@ private: const long nItemMinHeight = 38; }; -CustomAnimationListEntryItem::CustomAnimationListEntryItem( const OUString& aDescription, CustomAnimationEffectPtr pEffect, CustomAnimationList* pParent ) +CustomAnimationListEntryItem::CustomAnimationListEntryItem( const OUString& aDescription, const CustomAnimationEffectPtr& pEffect, CustomAnimationList* pParent ) : SvLBoxString( aDescription ) , mpParent( pParent ) , msDescription( aDescription ) @@ -349,7 +349,7 @@ class CustomAnimationListEntry : public SvTreeListEntry { public: CustomAnimationListEntry(); - explicit CustomAnimationListEntry( CustomAnimationEffectPtr pEffect ); + explicit CustomAnimationListEntry(const CustomAnimationEffectPtr& pEffect); virtual ~CustomAnimationListEntry(); const CustomAnimationEffectPtr& getEffect() const { return mpEffect; } @@ -362,7 +362,7 @@ CustomAnimationListEntry::CustomAnimationListEntry() { } -CustomAnimationListEntry::CustomAnimationListEntry( CustomAnimationEffectPtr pEffect ) +CustomAnimationListEntry::CustomAnimationListEntry(const CustomAnimationEffectPtr& pEffect) : mpEffect( pEffect ) { } diff --git a/sd/source/ui/dlg/RemoteDialogClientBox.cxx b/sd/source/ui/dlg/RemoteDialogClientBox.cxx index e6a654149d3c..a0861fd0d461 100644 --- a/sd/source/ui/dlg/RemoteDialogClientBox.cxx +++ b/sd/source/ui/dlg/RemoteDialogClientBox.cxx @@ -41,9 +41,9 @@ namespace sd { // struct ClientBoxEntry -ClientBoxEntry::ClientBoxEntry( std::shared_ptr<ClientInfo> pClientInfo ) : - m_bActive( false ), - m_pClientInfo( pClientInfo ) +ClientBoxEntry::ClientBoxEntry(const std::shared_ptr<ClientInfo>& pClientInfo) + : m_bActive(false) + , m_pClientInfo(pClientInfo) { } diff --git a/sd/source/ui/dlg/RemoteDialogClientBox.hxx b/sd/source/ui/dlg/RemoteDialogClientBox.hxx index b2d5718285ca..968a311127cd 100644 --- a/sd/source/ui/dlg/RemoteDialogClientBox.hxx +++ b/sd/source/ui/dlg/RemoteDialogClientBox.hxx @@ -59,7 +59,7 @@ struct ClientBoxEntry bool m_bActive :1; std::shared_ptr<ClientInfo> m_pClientInfo; - explicit ClientBoxEntry(std::shared_ptr<ClientInfo> pClientInfo); + explicit ClientBoxEntry(const std::shared_ptr<ClientInfo>& pClientInfo); ~ClientBoxEntry(); }; |