diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-12 15:07:39 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-13 09:17:34 +0200 |
commit | 0fdcfedd898afcc03332a432ef21052eee6b3a3a (patch) | |
tree | 46ed1c968570414ffa0917d2324863234cc504fe /sd | |
parent | d0d4a3647692883b17a1acd96a01a1857c5872b1 (diff) |
make SdrObjUserData::Clone return std::unique_ptr
Change-Id: Iffe047b081fde0bb582d8730a8e96d2597c7567a
Reviewed-on: https://gerrit.libreoffice.org/52780
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
-rw-r--r-- | sd/inc/anminfo.hxx | 2 | ||||
-rw-r--r-- | sd/inc/imapinfo.hxx | 2 | ||||
-rw-r--r-- | sd/source/core/anminfo.cxx | 4 | ||||
-rw-r--r-- | sd/source/core/drawdoc2.cxx | 2 | ||||
-rw-r--r-- | sd/source/ui/unoidl/unoobj.cxx | 2 | ||||
-rw-r--r-- | sd/source/ui/view/drviewsg.cxx | 2 | ||||
-rw-r--r-- | sd/source/ui/view/sdview3.cxx | 4 | ||||
-rw-r--r-- | sd/source/ui/view/sdview4.cxx | 6 |
8 files changed, 12 insertions, 12 deletions
diff --git a/sd/inc/anminfo.hxx b/sd/inc/anminfo.hxx index 444ee80e57b9..0fe0f2993f7d 100644 --- a/sd/inc/anminfo.hxx +++ b/sd/inc/anminfo.hxx @@ -65,7 +65,7 @@ public: SAL_DLLPRIVATE SdAnimationInfo(const SdAnimationInfo& rAnmInfo, SdrObject& rObject); SAL_DLLPRIVATE virtual ~SdAnimationInfo() override; - SAL_DLLPRIVATE virtual SdrObjUserData* Clone(SdrObject* pObject) const override; + SAL_DLLPRIVATE virtual std::unique_ptr<SdrObjUserData> Clone(SdrObject* pObject) const override; }; #endif // INCLUDED_SD_INC_ANMINFO_HXX diff --git a/sd/inc/imapinfo.hxx b/sd/inc/imapinfo.hxx index 3beaaa9b8aff..77c6c203b43f 100644 --- a/sd/inc/imapinfo.hxx +++ b/sd/inc/imapinfo.hxx @@ -40,7 +40,7 @@ public: SfxListener(), aImageMap( rIMapInfo.aImageMap ) {}; - virtual SdrObjUserData* Clone( SdrObject* ) const override { return new SdIMapInfo( *this ); } + virtual std::unique_ptr<SdrObjUserData> Clone( SdrObject* ) const override { return std::unique_ptr<SdrObjUserData>(new SdIMapInfo( *this )); } void SetImageMap( const ImageMap& rIMap ) { aImageMap = rIMap; } const ImageMap& GetImageMap() const { return aImageMap; } diff --git a/sd/source/core/anminfo.cxx b/sd/source/core/anminfo.cxx index b3192a2e97cf..9979181b45fd 100644 --- a/sd/source/core/anminfo.cxx +++ b/sd/source/core/anminfo.cxx @@ -89,13 +89,13 @@ SdAnimationInfo::~SdAnimationInfo() { } -SdrObjUserData* SdAnimationInfo::Clone(SdrObject* pObject) const +std::unique_ptr<SdrObjUserData> SdAnimationInfo::Clone(SdrObject* pObject) const { DBG_ASSERT( pObject, "SdAnimationInfo::Clone(), pObject must not be null!" ); if( pObject == nullptr ) pObject = &mrObject; - return new SdAnimationInfo(*this, *pObject ); + return std::unique_ptr<SdrObjUserData>(new SdAnimationInfo(*this, *pObject )); } void SdAnimationInfo::SetBookmark( const OUString& rBookmark ) diff --git a/sd/source/core/drawdoc2.cxx b/sd/source/core/drawdoc2.cxx index 0652a9aa812d..3a0cc03e341c 100644 --- a/sd/source/core/drawdoc2.cxx +++ b/sd/source/core/drawdoc2.cxx @@ -1004,7 +1004,7 @@ SdAnimationInfo* SdDrawDocument::GetShapeUserData(SdrObject& rObject, bool bCrea if( (pRet == nullptr) && bCreate ) { pRet = new SdAnimationInfo( rObject ); - rObject.AppendUserData( pRet); + rObject.AppendUserData( std::unique_ptr<SdrObjUserData>(pRet) ); } return pRet; diff --git a/sd/source/ui/unoidl/unoobj.cxx b/sd/source/ui/unoidl/unoobj.cxx index d87831dc5702..588f4449c8a3 100644 --- a/sd/source/ui/unoidl/unoobj.cxx +++ b/sd/source/ui/unoidl/unoobj.cxx @@ -645,7 +645,7 @@ void SAL_CALL SdXShape::setPropertyValue( const OUString& aPropertyName, const c else { // insert new user data with image map - pObj->AppendUserData(new SdIMapInfo(aImageMap) ); + pObj->AppendUserData(std::unique_ptr<SdrObjUserData>(new SdIMapInfo(aImageMap) )); } } } diff --git a/sd/source/ui/view/drviewsg.cxx b/sd/source/ui/view/drviewsg.cxx index f4f9933792cd..b989b84105c7 100644 --- a/sd/source/ui/view/drviewsg.cxx +++ b/sd/source/ui/view/drviewsg.cxx @@ -62,7 +62,7 @@ void DrawViewShell::ExecIMap( SfxRequest const & rReq ) SdIMapInfo* pIMapInfo = SdDrawDocument::GetIMapInfo( pSdrObj ); if ( !pIMapInfo ) - pSdrObj->AppendUserData( new SdIMapInfo( rImageMap ) ); + pSdrObj->AppendUserData( std::unique_ptr<SdrObjUserData>(new SdIMapInfo( rImageMap )) ); else pIMapInfo->SetImageMap( rImageMap ); diff --git a/sd/source/ui/view/sdview3.cxx b/sd/source/ui/view/sdview3.cxx index cf6f72870045..73f06ae8f975 100644 --- a/sd/source/ui/view/sdview3.cxx +++ b/sd/source/ui/view/sdview3.cxx @@ -1019,7 +1019,7 @@ bool View::InsertData( const TransferableDataHelper& rDataHelper, InsertObjectAtView( pObj, *pPV, nOptions ); if( pImageMap ) - pObj->AppendUserData( new SdIMapInfo( *pImageMap ) ); + pObj->AppendUserData( std::unique_ptr<SdrObjUserData>(new SdIMapInfo( *pImageMap )) ); if (pObj->IsChart()) { @@ -1193,7 +1193,7 @@ bool View::InsertData( const TransferableDataHelper& rDataHelper, InsertObjectAtView( pObj, *pPV, nOptions ); if( pImageMap ) - pObj->AppendUserData( new SdIMapInfo( *pImageMap ) ); + pObj->AppendUserData( std::unique_ptr<SdrObjUserData>(new SdIMapInfo( *pImageMap )) ); // let the object stay in loaded state after insertion pObj->Unload(); diff --git a/sd/source/ui/view/sdview4.cxx b/sd/source/ui/view/sdview4.cxx index fb17fcc2df24..0a8792cd8538 100644 --- a/sd/source/ui/view/sdview4.cxx +++ b/sd/source/ui/view/sdview4.cxx @@ -139,7 +139,7 @@ SdrGrafObj* View::InsertGraphic( const Graphic& rGraphic, sal_Int8& rAction, } if (pImageMap) - pNewGrafObj->AppendUserData(new SdIMapInfo(*pImageMap)); + pNewGrafObj->AppendUserData(std::unique_ptr<SdrObjUserData>(new SdIMapInfo(*pImageMap))); ReplaceObjectAtView(pPickObj, *pPV, pNewGrafObj); // maybe ReplaceObjectAtView @@ -224,7 +224,7 @@ SdrGrafObj* View::InsertGraphic( const Graphic& rGraphic, sal_Int8& rAction, { // replace object if (pImageMap) - pNewGrafObj->AppendUserData(new SdIMapInfo(*pImageMap)); + pNewGrafObj->AppendUserData(std::unique_ptr<SdrObjUserData>(new SdIMapInfo(*pImageMap))); ::tools::Rectangle aPickObjRect(pPickObj->GetCurrentBoundRect()); Size aPickObjSize(aPickObjRect.GetSize()); @@ -267,7 +267,7 @@ SdrGrafObj* View::InsertGraphic( const Graphic& rGraphic, sal_Int8& rAction, InsertObjectAtView(pNewGrafObj, *pPV, nOptions); if( pImageMap ) - pNewGrafObj->AppendUserData(new SdIMapInfo(*pImageMap)); + pNewGrafObj->AppendUserData(std::unique_ptr<SdrObjUserData>(new SdIMapInfo(*pImageMap))); } } |