diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-17 10:59:34 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2016-11-21 06:19:52 +0000 |
| commit | 04f262ace019dc87bb52f32c42107a8f2b348d89 (patch) | |
| tree | 75ee786039a4eb63962ff1dee80cb64c3aee459a /sd | |
| parent | bbe19c1312500c63748583eb2e64f5cd1190942c (diff) | |
new loplugin datamembershadow
Change-Id: Ib14319848bafd1fe7e0e663c434bbdeef5e98ecf
Reviewed-on: https://gerrit.libreoffice.org/30963
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/inc/sdundo.hxx | 3 | ||||
| -rw-r--r-- | sd/source/core/annotations/Annotation.cxx | 1 | ||||
| -rw-r--r-- | sd/source/ui/inc/unmodpg.hxx | 4 | ||||
| -rw-r--r-- | sd/source/ui/view/unmodpg.cxx | 7 |
4 files changed, 3 insertions, 12 deletions
diff --git a/sd/inc/sdundo.hxx b/sd/inc/sdundo.hxx index c7041399daac..fa2d06ee8cd6 100644 --- a/sd/inc/sdundo.hxx +++ b/sd/inc/sdundo.hxx @@ -39,8 +39,9 @@ public: protected: SdDrawDocument* mpDoc; - OUString maComment; sal_Int32 mnViewShellId; +private: + OUString maComment; }; #endif // INCLUDED_SD_INC_SDUNDO_HXX diff --git a/sd/source/core/annotations/Annotation.cxx b/sd/source/core/annotations/Annotation.cxx index 52e999579e19..88af7562d06a 100644 --- a/sd/source/core/annotations/Annotation.cxx +++ b/sd/source/core/annotations/Annotation.cxx @@ -100,7 +100,6 @@ private: virtual void SAL_CALL disposing() override; SdPage* mpPage; - mutable ::osl::Mutex m_aMutex; RealPoint2D m_Position; RealSize2D m_Size; OUString m_Author; diff --git a/sd/source/ui/inc/unmodpg.hxx b/sd/source/ui/inc/unmodpg.hxx index c48482a00cc0..664740675319 100644 --- a/sd/source/ui/inc/unmodpg.hxx +++ b/sd/source/ui/inc/unmodpg.hxx @@ -38,8 +38,6 @@ class ModifyPageUndoAction : public SdUndoAction bool mbOldBckgrndObjsVisible; bool mbNewBckgrndObjsVisible; - OUString maComment; - public: ModifyPageUndoAction( SdDrawDocument* pTheDoc, @@ -52,8 +50,6 @@ public: virtual ~ModifyPageUndoAction() override; virtual void Undo() override; virtual void Redo() override; - - virtual OUString GetComment() const override; }; class RenameLayoutTemplateUndoAction : public SdUndoAction diff --git a/sd/source/ui/view/unmodpg.cxx b/sd/source/ui/view/unmodpg.cxx index 7da13920730f..ac3176c2887f 100644 --- a/sd/source/ui/view/unmodpg.cxx +++ b/sd/source/ui/view/unmodpg.cxx @@ -70,7 +70,7 @@ ModifyPageUndoAction::ModifyPageUndoAction( mbOldBckgrndObjsVisible = false; } - maComment = SD_RESSTR(STR_UNDO_MODIFY_PAGE); + SetComment( SD_RESSTR(STR_UNDO_MODIFY_PAGE) ); } void ModifyPageUndoAction::Undo() @@ -163,11 +163,6 @@ ModifyPageUndoAction::~ModifyPageUndoAction() { } -OUString ModifyPageUndoAction::GetComment() const -{ - return maComment; -} - RenameLayoutTemplateUndoAction::RenameLayoutTemplateUndoAction( SdDrawDocument* pDocument, const OUString& rOldLayoutName, |