diff options
| author | Caolán McNamara <caolanm@redhat.com> | 2018-10-10 12:18:13 +0100 |
|---|---|---|
| committer | Caolán McNamara <caolanm@redhat.com> | 2018-10-10 16:57:12 +0200 |
| commit | 3b21fed4b153e3bbf1d47c3073f31a3735538596 (patch) | |
| tree | dc9fb83579f454713d8cd44df3d8627bc826e564 /sd | |
| parent | ee68b450b75c68b2b129564c799766abba7087c9 (diff) | |
optimize adding a block of entries at one time
Change-Id: I9a59154fa445cf3c44ede3ceb1d09f408d906530
Reviewed-on: https://gerrit.libreoffice.org/61618
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/source/ui/dlg/PhotoAlbumDialog.cxx | 8 | ||||
| -rw-r--r-- | sd/source/ui/dlg/custsdlg.cxx | 5 |
2 files changed, 7 insertions, 6 deletions
diff --git a/sd/source/ui/dlg/PhotoAlbumDialog.cxx b/sd/source/ui/dlg/PhotoAlbumDialog.cxx index 403876b7c3da..934e3be37217 100644 --- a/sd/source/ui/dlg/PhotoAlbumDialog.cxx +++ b/sd/source/ui/dlg/PhotoAlbumDialog.cxx @@ -550,8 +550,8 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, UpHdl, weld::Button&, void) m_xImagesLst->remove_text(sActEntry); m_xImagesLst->remove_text(sUpperEntry); - m_xImagesLst->insert(nActPos - 1, sAct, sActEntry, nullptr, nullptr); - m_xImagesLst->insert(nActPos, sUpper, sUpperEntry, nullptr, nullptr); + m_xImagesLst->insert(nActPos - 1, sActEntry, &sAct, nullptr, nullptr); + m_xImagesLst->insert(nActPos, sUpperEntry, &sUpper, nullptr, nullptr); m_xImagesLst->select(nActPos - 1); } @@ -573,8 +573,8 @@ IMPL_LINK_NOARG(SdPhotoAlbumDialog, DownHdl, weld::Button&, void) m_xImagesLst->remove_text(sActEntry); m_xImagesLst->remove_text(sDownEntry); - m_xImagesLst->insert(nActPos, sDown, sDownEntry, nullptr, nullptr); - m_xImagesLst->insert(nActPos + 1, sAct, sActEntry, nullptr, nullptr); + m_xImagesLst->insert(nActPos, sDownEntry, &sDown, nullptr, nullptr); + m_xImagesLst->insert(nActPos + 1, sActEntry, &sAct, nullptr, nullptr); m_xImagesLst->select(nActPos + 1); } diff --git a/sd/source/ui/dlg/custsdlg.cxx b/sd/source/ui/dlg/custsdlg.cxx index b7b384073666..da736e59f8ac 100644 --- a/sd/source/ui/dlg/custsdlg.cxx +++ b/sd/source/ui/dlg/custsdlg.cxx @@ -154,7 +154,7 @@ void SdCustomShowDlg::SelectHdl(void const *p) (*pCustomShowList)[nPos] = pCustomShow; pCustomShowList->Seek(nPos); m_xLbCustomShows->remove(nPos); - m_xLbCustomShows->insert_text(pCustomShow->GetName(), nPos); + m_xLbCustomShows->insert_text(nPos, pCustomShow->GetName()); m_xLbCustomShows->select(nPos); } if (aDlg.IsModified()) @@ -378,7 +378,8 @@ void SdDefineCustomShowDlg::ClickButtonHdl2(void const * p) { OUString aStr = m_xLbPages->get_text(i); SdPage* pPage = rDoc.GetSdPage(i, PageKind::Standard); - m_xLbCustomPages->insert(nPosCP, OUString::number(reinterpret_cast<sal_uInt64>(pPage)), aStr, nullptr, nullptr); + OUString sId(OUString::number(reinterpret_cast<sal_uInt64>(pPage))); + m_xLbCustomPages->insert(nPosCP, aStr, &sId, nullptr, nullptr); m_xLbCustomPages->select(nPosCP != -1 ? nPosCP : m_xLbCustomPages->n_children() - 1); if (nPosCP != -1) |