diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-10 11:05:49 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-12 08:56:58 +0200 |
| commit | ce47f6dade0802d61b298e9490605894d94f6762 (patch) | |
| tree | 64dadb0088cf780ac8ccf15a7f1602b224974678 /sd | |
| parent | e75baaa5dfffd96da55b892dd26ffec37ad5080c (diff) | |
loplugin:useuniqueptr in SdDrawDocument::InsertBookmarkAsObject
Change-Id: Ib46259a87152a491f6fcad2c8fc5d2aa1f0f9531
Reviewed-on: https://gerrit.libreoffice.org/60337
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/source/core/drawdoc3.cxx | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/sd/source/core/drawdoc3.cxx b/sd/source/core/drawdoc3.cxx index 557e836bf39c..74373005298a 100644 --- a/sd/source/core/drawdoc3.cxx +++ b/sd/source/core/drawdoc3.cxx @@ -978,7 +978,7 @@ bool SdDrawDocument::InsertBookmarkAsObject( { bool bOK = true; bool bOLEObjFound = false; - ::sd::View* pBMView = nullptr; + std::unique_ptr<::sd::View> pBMView; SdDrawDocument* pBookmarkDoc = nullptr; @@ -997,7 +997,7 @@ bool SdDrawDocument::InsertBookmarkAsObject( if (rBookmarkList.empty()) { - pBMView = new ::sd::View(*pBookmarkDoc, nullptr); + pBMView.reset(new ::sd::View(*pBookmarkDoc, nullptr)); pBMView->EndListening(*pBookmarkDoc); pBMView->MarkAll(); } @@ -1024,7 +1024,7 @@ bool SdDrawDocument::InsertBookmarkAsObject( if (!pBMView) { // Create View for the first time - pBMView = new ::sd::View(*pBookmarkDoc, nullptr); + pBMView.reset(new ::sd::View(*pBookmarkDoc, nullptr)); pBMView->EndListening(*pBookmarkDoc); } @@ -1131,8 +1131,6 @@ bool SdDrawDocument::InsertBookmarkAsObject( } } - delete pBMView; - return bOK; } |