diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-08-18 09:43:04 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-08-18 16:02:25 +0200 |
| commit | 65ae6af9f460b1a28f3e07480347ff7f90adae38 (patch) | |
| tree | 49bfeb1e25724d3b5539b7b5843d38b7531cf65f /sd | |
| parent | c7d1bb119d88faaafb53d65ad8907ede97d89c8c (diff) | |
loplugin:unusedvarsglobal
tackle some read-only vars.
Mark some of them const to make it obvious they are not really used, and
to make the constantparam plugin see more data.
Change-Id: Ia25927745866746aa1aa9d5affd5857ad9f9ee24
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100895
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/source/core/drawdoc4.cxx | 2 | ||||
| -rw-r--r-- | sd/source/core/stlpool.cxx | 4 | ||||
| -rw-r--r-- | sd/source/ui/view/sdview3.cxx | 5 |
3 files changed, 5 insertions, 6 deletions
diff --git a/sd/source/core/drawdoc4.cxx b/sd/source/core/drawdoc4.cxx index 7eb550dea115..f23ae2024a9e 100644 --- a/sd/source/core/drawdoc4.cxx +++ b/sd/source/core/drawdoc4.cxx @@ -124,7 +124,7 @@ void SdDrawDocument::CreateLayoutTemplates() { SdStyleSheetPool* pSSPool = static_cast<SdStyleSheetPool*>(GetStyleSheetPool()); SfxStyleSheetBase* pSheet = nullptr; - OUString aHelpFile; + const OUString aHelpFile; OUString aStdName(SdResId(STR_STANDARD_STYLESHEET_NAME)); // Default style diff --git a/sd/source/core/stlpool.cxx b/sd/source/core/stlpool.cxx index e5f1ddf8cf7a..2419eaa354f9 100644 --- a/sd/source/core/stlpool.cxx +++ b/sd/source/core/stlpool.cxx @@ -197,7 +197,7 @@ void SdStyleSheetPool::CreateLayoutStyleSheets(const OUString& rLayoutName, bool * outline levels **************************************************************************/ OUString aName(STR_LAYOUT_OUTLINE); - OUString aHelpFile; + const OUString aHelpFile; SvxLRSpaceItem aSvxLRSpaceItem( EE_PARA_LRSPACE ); SvxULSpaceItem aSvxULSpaceItem( EE_PARA_ULSPACE ); @@ -820,7 +820,7 @@ void SdStyleSheetPool::CreateLayoutSheetList(const OUString& rLayoutName, SdStyl void SdStyleSheetPool::CreatePseudosIfNecessary() { OUString aName; - OUString aHelpFile; + const OUString aHelpFile; SfxStyleSheetBase* pSheet = nullptr; SfxStyleSheetBase* pParent = nullptr; diff --git a/sd/source/ui/view/sdview3.cxx b/sd/source/ui/view/sdview3.cxx index 1ecd4aa48efe..c3508ec217fc 100644 --- a/sd/source/ui/view/sdview3.cxx +++ b/sd/source/ui/view/sdview3.cxx @@ -1341,7 +1341,6 @@ bool View::InsertData( const TransferableDataHelper& rDataHelper, if( eFill == drawing::FillStyle_SOLID || eFill == drawing::FillStyle_NONE ) { - OUString aName; SfxItemSet aSet( mrDoc.GetPool() ); bool bClosed = pPickObj->IsClosedObj(); ::sd::Window* pWin = mpViewSh->GetActiveWindow(); @@ -1367,12 +1366,12 @@ bool View::InsertData( const TransferableDataHelper& rDataHelper, { // area fill if(eFill == drawing::FillStyle_SOLID ) - aSet.Put(XFillColorItem(aName, aColor)); + aSet.Put(XFillColorItem("", aColor)); aSet.Put( XFillStyleItem( eFill ) ); } else - aSet.Put( XLineColorItem( aName, aColor ) ); + aSet.Put( XLineColorItem( "", aColor ) ); // add text color pPickObj->SetMergedItemSetAndBroadcast( aSet ); |