diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-10 09:08:07 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-05-10 11:34:18 +0200 |
commit | 0e384e1080381e894b590fd0a6d453568715e8fa (patch) | |
tree | 1f91b14d4140219c6bfcaacf85d755facdc34d40 /sd | |
parent | 6ede622ab6d2393c3ec90fcaa6e2487232b8c1a8 (diff) |
loplugin:unnecessaryvirtual improvements
look for virtual methods where all of the overrides of the method are
empty
Change-Id: I87d99a0b647700a8d53498e0ab5f0437d3508553
Reviewed-on: https://gerrit.libreoffice.org/54060
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
-rw-r--r-- | sd/source/filter/eppt/epptbase.hxx | 1 | ||||
-rw-r--r-- | sd/source/filter/eppt/epptooxml.hxx | 1 | ||||
-rw-r--r-- | sd/source/filter/eppt/pptx-epptbase.cxx | 8 | ||||
-rw-r--r-- | sd/source/filter/eppt/pptx-epptooxml.cxx | 6 |
4 files changed, 0 insertions, 16 deletions
diff --git a/sd/source/filter/eppt/epptbase.hxx b/sd/source/filter/eppt/epptbase.hxx index b0b391697f5a..cf61a2d3ac6f 100644 --- a/sd/source/filter/eppt/epptbase.hxx +++ b/sd/source/filter/eppt/epptbase.hxx @@ -353,7 +353,6 @@ protected: bool /* bHasBackground */, css::uno::Reference< css::beans::XPropertySet > const & /* aXBackgroundPropSet */ ) {} virtual void ImplWriteNotes( sal_uInt32 nPageNum ) = 0; virtual void ImplWriteSlideMaster( sal_uInt32 /* nPageNum */, css::uno::Reference< css::beans::XPropertySet > const & /* aXBackgroundPropSet */ ) {} - virtual void ImplWriteLayout( sal_Int32 /* nOffset */, sal_uInt32 /* nMasterNum */ ) {} virtual void exportPPTPre( const std::vector< css::beans::PropertyValue >& ) {} virtual void exportPPTPost() {} diff --git a/sd/source/filter/eppt/epptooxml.hxx b/sd/source/filter/eppt/epptooxml.hxx index d9289b2bedcf..7fff989cc23d 100644 --- a/sd/source/filter/eppt/epptooxml.hxx +++ b/sd/source/filter/eppt/epptooxml.hxx @@ -90,7 +90,6 @@ private: bool bHasBackground, css::uno::Reference< css::beans::XPropertySet > const & aXBackgroundPropSet ) override; virtual void ImplWriteNotes( sal_uInt32 nPageNum ) override; virtual void ImplWriteSlideMaster( sal_uInt32 nPageNum, css::uno::Reference< css::beans::XPropertySet > const & aXBackgroundPropSet ) override; - virtual void ImplWriteLayout( sal_Int32 nOffset, sal_uInt32 nMasterNum ) override; void ImplWritePPTXLayout( sal_Int32 nOffset, sal_uInt32 nMasterNum ); bool WriteColorSchemes(FSHelperPtr pFS, const OUString& rThemePath); void WriteDefaultColorSchemes(FSHelperPtr pFS); diff --git a/sd/source/filter/eppt/pptx-epptbase.cxx b/sd/source/filter/eppt/pptx-epptbase.cxx index b3e1c4787645..22c6d0fa143d 100644 --- a/sd/source/filter/eppt/pptx-epptbase.cxx +++ b/sd/source/filter/eppt/pptx-epptbase.cxx @@ -211,14 +211,6 @@ void PPTWriterBase::exportPPT( const std::vector< css::beans::PropertyValue >& r sal_uInt32 i; - for ( i = 0; i < mnPages; i++ ) - { - if ( GetPageByIndex( i, NORMAL ) ) { - sal_uInt32 nMasterNum = GetMasterIndex( NORMAL ); - ImplWriteLayout( GetLayoutOffset( mXPagePropSet ), nMasterNum ); - } - } - for ( i = 0; i < mnMasterPages; i++ ) { if ( !CreateSlideMaster( i ) ) diff --git a/sd/source/filter/eppt/pptx-epptooxml.cxx b/sd/source/filter/eppt/pptx-epptooxml.cxx index 33071ee3817a..f33c62db57dd 100644 --- a/sd/source/filter/eppt/pptx-epptooxml.cxx +++ b/sd/source/filter/eppt/pptx-epptooxml.cxx @@ -2206,12 +2206,6 @@ sal_Int32 PowerPointExport::GetLayoutFileId(sal_Int32 nOffset, sal_uInt32 nMaste return mLayoutInfo[ nOffset ].mnFileIdArray[ nMasterNum ]; } -void PowerPointExport::ImplWriteLayout(sal_Int32 /*nOffset*/, sal_uInt32 /*nMasterNum*/) -{ - // we write all the layouts together with master(s) - // ImplWritePPTXLayout( GetPPTXLayoutId( nOffset ), nMasterNum ); -} - void PowerPointExport::ImplWritePPTXLayout(sal_Int32 nOffset, sal_uInt32 nMasterNum) { SAL_INFO("sd.eppt", "write layout: " << nOffset); |