diff options
| author | Jochen Nitschke <j.nitschke+logerrit@ok.de> | 2017-01-23 09:01:42 +0100 |
|---|---|---|
| committer | Jochen Nitschke <j.nitschke+logerrit@ok.de> | 2017-01-23 13:50:45 +0000 |
| commit | abc8057ab1a1189ff7f88d42b13b363ceb228d16 (patch) | |
| tree | 20145fa90c9a1bf91dea3489d384fe6d28ac2ec0 /sd | |
| parent | 5f1bc19a9a0dbdf88e11ef81cc8c2f302748632c (diff) | |
pass ownership by pointer
to show the intend of the code.
assert on invalid objects.
remove useless OSL_ENSURE.
make sure list of owning pointers can't be copied.
Change-Id: I3cccf8ea87585ec9fe62921203a4d12e617ce15c
Reviewed-on: https://gerrit.libreoffice.org/33393
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/source/ui/animations/motionpathtag.cxx | 2 | ||||
| -rw-r--r-- | sd/source/ui/annotations/annotationtag.cxx | 2 | ||||
| -rw-r--r-- | sd/source/ui/view/viewoverlaymanager.cxx | 2 |
3 files changed, 3 insertions, 3 deletions
diff --git a/sd/source/ui/animations/motionpathtag.cxx b/sd/source/ui/animations/motionpathtag.cxx index 3d5c436ca5fa..a05b01182ce4 100644 --- a/sd/source/ui/animations/motionpathtag.cxx +++ b/sd/source/ui/animations/motionpathtag.cxx @@ -289,7 +289,7 @@ void SdPathHdl::CreateB2dIAObject() sdr::overlay::OverlayObject* pNew = new sdr::overlay::OverlayPrimitive2DSequenceObject(aSequence); xManager->add(*pNew); - maOverlayGroup.append(*pNew); + maOverlayGroup.append(pNew); } } } diff --git a/sd/source/ui/annotations/annotationtag.cxx b/sd/source/ui/annotations/annotationtag.cxx index fe740b524273..0251af279c9f 100644 --- a/sd/source/ui/annotations/annotationtag.cxx +++ b/sd/source/ui/annotations/annotationtag.cxx @@ -225,7 +225,7 @@ void AnnotationHdl::CreateB2dIAObject() } xManager->add(*pOverlayObject); - maOverlayGroup.append(*pOverlayObject); + maOverlayGroup.append(pOverlayObject); } } } diff --git a/sd/source/ui/view/viewoverlaymanager.cxx b/sd/source/ui/view/viewoverlaymanager.cxx index 008705d72357..476593a36f64 100644 --- a/sd/source/ui/view/viewoverlaymanager.cxx +++ b/sd/source/ui/view/viewoverlaymanager.cxx @@ -240,7 +240,7 @@ void ImageButtonHdl::CreateB2dIAObject() pOverlayObject = new sdr::overlay::OverlayBitmapEx( aPosition, aBitmapEx, 0, 0 ); xManager->add(*pOverlayObject); - maOverlayGroup.append(*pOverlayObject); + maOverlayGroup.append(pOverlayObject); } } } |