summaryrefslogtreecommitdiff
path: root/sd
diff options
context:
space:
mode:
authorAron Budea <aron.budea@collabora.com>2019-12-22 08:10:25 +0100
committerAshod Nakashian <ashnakash@gmail.com>2019-12-22 22:10:08 +0100
commitcfe24288e43779019bf755dfdff9163e0be2e4e2 (patch)
treee410f08fb96b3da89230541cef82872e40fcc4c9 /sd
parentfdc331d7ec0d4d9e6c074eb295d803686946e5ac (diff)
tdf#128449 Set graphic when setting background in Impress
Regression from 905e6bd3ae0ca5c5ac7083430d7aa126c6526fd7 Change-Id: If0510967a339b6b46da2b7f798f478a46bd10b48 Reviewed-on: https://gerrit.libreoffice.org/85688 Tested-by: Jenkins Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 8304c671b19365e61d88a9133631775846a172a5) Reviewed-on: https://gerrit.libreoffice.org/85703
Diffstat (limited to 'sd')
-rw-r--r--sd/source/ui/func/fupage.cxx9
1 files changed, 3 insertions, 6 deletions
diff --git a/sd/source/ui/func/fupage.cxx b/sd/source/ui/func/fupage.cxx
index 7c2654e0bba0..95dc91b232f2 100644
--- a/sd/source/ui/func/fupage.cxx
+++ b/sd/source/ui/func/fupage.cxx
@@ -293,8 +293,6 @@ const SfxItemSet* FuPage::ExecuteDialog(weld::Window* pParent, const SfxRequest&
}
else if (nId == SID_SELECT_BACKGROUND)
{
- OUString aFileName;
- OUString aFilterName;
Graphic aGraphic;
ErrCode nError = ERRCODE_GRFILTER_OPENERROR;
@@ -303,7 +301,8 @@ const SfxItemSet* FuPage::ExecuteDialog(weld::Window* pParent, const SfxRequest&
if (pArgs && pArgs->GetItemState(SID_SELECT_BACKGROUND, true, &pItem) == SfxItemState::SET)
{
- aFileName = static_cast<const SfxStringItem*>(pItem)->GetValue();
+ OUString aFileName(static_cast<const SfxStringItem*>(pItem)->GetValue());
+ OUString aFilterName;
if (pArgs->GetItemState(FN_PARAM_FILTER, true, &pItem) == SfxItemState::SET)
aFilterName = static_cast<const SfxStringItem*>(pItem)->GetValue();
@@ -316,11 +315,9 @@ const SfxItemSet* FuPage::ExecuteDialog(weld::Window* pParent, const SfxRequest&
SvxOpenGraphicDialog aDlg(SdResId(STR_SET_BACKGROUND_PICTURE), pParent);
nError = aDlg.Execute();
- if (nError != ERRCODE_NONE)
+ if (nError == ERRCODE_NONE)
{
nError = aDlg.GetGraphic(aGraphic);
- aFileName = aDlg.GetPath();
- aFilterName = aDlg.GetDetectedFilter();
}
}