diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-08-23 13:47:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2023-08-28 09:43:40 +0200 |
| commit | 68e797402692c5c8abf1b2c4374e12a8d2707d07 (patch) | |
| tree | d10643f2ce00efe809de0e9548a2c38943e2d11f /sd | |
| parent | 5733cdba90b099637805648b193510268def74be (diff) | |
new loplugin:optionalbool
which warns against using the 'operator bool' conversion of
std::optional<bool> which can lead to interesting bugs
The bugs that this plugin have been submitted independantly,
so this change is just using has_value() in relevant places.
Change-Id: I259b837feeecddcb8cd1d7e5db1e85bf505907cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155978
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/source/ui/view/drviews7.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/sd/source/ui/view/drviews7.cxx b/sd/source/ui/view/drviews7.cxx index a2f12e9ccaef..3bace958df28 100644 --- a/sd/source/ui/view/drviews7.cxx +++ b/sd/source/ui/view/drviews7.cxx @@ -1480,7 +1480,7 @@ void DrawViewShell::GetMenuState( SfxItemSet &rSet ) // Menuoption: Edit->Hyperlink // Disable, if there is no hyperlink bool bDisableEditHyperlink; - if (!moAtContextMenu_DisableEditHyperlink) + if (!moAtContextMenu_DisableEditHyperlink.has_value()) bDisableEditHyperlink = ShouldDisableEditHyperlink(); else { |