diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-06-09 08:36:33 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2022-06-10 13:13:15 +0200 |
| commit | f71606c920a3f78294da745cd9ef1eacde010224 (patch) | |
| tree | b808351112a9b13fb775f7794d18b0cb8b6e1645 /sd | |
| parent | b28de9d32016a904e4ba457a9a6c62098416c729 (diff) | |
new loplugin:moveit
look for local variables that can be std::move'd to parameters
off by default, since it doesn't do proper data flow analysis
Change-Id: I3403a0fcffd165bdea6a772528bc53995c5fdb40
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135527
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sd')
| -rw-r--r-- | sd/source/core/drawdoc.cxx | 3 | ||||
| -rw-r--r-- | sd/source/ui/animations/CustomAnimationList.cxx | 2 |
2 files changed, 2 insertions, 3 deletions
diff --git a/sd/source/core/drawdoc.cxx b/sd/source/core/drawdoc.cxx index 796bbe1a477b..182ffe7f2c30 100644 --- a/sd/source/core/drawdoc.cxx +++ b/sd/source/core/drawdoc.cxx @@ -198,8 +198,7 @@ SdDrawDocument::SdDrawDocument(DocumentType eType, SfxObjectShell* pDrDocSh) } LanguageType eRealLanguage = MsLangId::getRealLanguage( meLanguage ); - LanguageTag aLanguageTag( eRealLanguage); - mpCharClass.reset(new CharClass( aLanguageTag )); + mpCharClass.reset(new CharClass( LanguageTag( eRealLanguage) )); // If the current application language is a language that uses right-to-left text... LanguageType eRealCTLLanguage = Application::GetSettings().GetLanguageTag().getLanguageType(); diff --git a/sd/source/ui/animations/CustomAnimationList.cxx b/sd/source/ui/animations/CustomAnimationList.cxx index db8bcf126405..cc85ed74f615 100644 --- a/sd/source/ui/animations/CustomAnimationList.cxx +++ b/sd/source/ui/animations/CustomAnimationList.cxx @@ -538,7 +538,7 @@ sal_Int8 CustomAnimationList::ExecuteDrop(const ExecuteDropEvent& rEvt) // Callback to observer to have it update the model. // If pTarget is null, pass nullptr to indicate end of list. mpController->onDragNDropComplete( - aEffects, + std::move(aEffects), pTarget ? pTarget->getEffect() : nullptr ); // Reset selection |