diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-25 08:53:14 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-25 12:15:44 +0100 |
commit | 390fad39a8f945c848ff998d9f75720318781123 (patch) | |
tree | 6338d12d31601635d6e079e7bb96e94eaa0642f3 /sdext/source/presenter/PresenterPaneBase.cxx | |
parent | a626e249033fb9a7ac117e28f3152cedf98b61fc (diff) |
loplugin:datamembershadow in PresenterPane
the subclass field is just a copy of the parent field, so drop the
subclass, and consequently simply the CreateCanvases method, we don't
need to pass the parameter down, can just access the parent field.
Change-Id: I3be448a06b32d01cdda4fc36b78cafb4488e2913
Reviewed-on: https://gerrit.libreoffice.org/48553
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sdext/source/presenter/PresenterPaneBase.cxx')
-rw-r--r-- | sdext/source/presenter/PresenterPaneBase.cxx | 9 |
1 files changed, 4 insertions, 5 deletions
diff --git a/sdext/source/presenter/PresenterPaneBase.cxx b/sdext/source/presenter/PresenterPaneBase.cxx index 4f8dc23e2573..f6174652b103 100644 --- a/sdext/source/presenter/PresenterPaneBase.cxx +++ b/sdext/source/presenter/PresenterPaneBase.cxx @@ -197,7 +197,7 @@ void SAL_CALL PresenterPaneBase::initialize (const Sequence<Any>& rArguments) 5); } - CreateWindows(mxParentWindow, bIsWindowVisibleOnCreation); + CreateWindows(bIsWindowVisibleOnCreation); if (mxBorderWindow.is()) { @@ -205,7 +205,7 @@ void SAL_CALL PresenterPaneBase::initialize (const Sequence<Any>& rArguments) mxBorderWindow->addPaintListener(this); } - CreateCanvases(mxParentWindow, xParentCanvas); + CreateCanvases(xParentCanvas); // Raise new windows. ToTop(); @@ -265,14 +265,13 @@ void SAL_CALL PresenterPaneBase::disposing (const lang::EventObject& rEvent) void PresenterPaneBase::CreateWindows ( - const Reference<awt::XWindow>& rxParentWindow, const bool bIsWindowVisibleOnCreation) { - if (mxPresenterHelper.is() && rxParentWindow.is()) + if (mxPresenterHelper.is() && mxParentWindow.is()) { mxBorderWindow = mxPresenterHelper->createWindow( - rxParentWindow, + mxParentWindow, false, bIsWindowVisibleOnCreation, false, |