teach loplugin:constantparam about simple constructor calls

Change-Id: I7d2a28ab5951fbdb5a427c84e9ac4c1e32ecf9f9
Reviewed-on: https://gerrit.libreoffice.org/37280
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

8 files changed, 6 insertions, 25 deletions

diff --git a/sdext/source/presenter/PresenterController.cxx b/sdext/source/presenter/PresenterController.cxx
index 477ad680ff7c..1d0705eeb094 100644
--- a/sdext/source/presenter/PresenterController.cxx
+++ b/sdext/source/presenter/PresenterController.cxx
@@ -1136,7 +1136,7 @@ void PresenterController::LoadTheme (const Reference<XPane>& rxPane)
 {
     // Create (load) the current theme.
     if (rxPane.is())
-        mpTheme.reset(new PresenterTheme(mxComponentContext, OUString(), rxPane->getCanvas()));
+        mpTheme.reset(new PresenterTheme(mxComponentContext, rxPane->getCanvas()));
 }
 
 double PresenterController::GetSlideAspectRatio() const
diff --git a/sdext/source/presenter/PresenterFrameworkObserver.cxx b/sdext/source/presenter/PresenterFrameworkObserver.cxx
index d35c378f3aff..b153f385acf8 100644
--- a/sdext/source/presenter/PresenterFrameworkObserver.cxx
+++ b/sdext/source/presenter/PresenterFrameworkObserver.cxx
@@ -29,7 +29,6 @@ namespace sdext { namespace presenter {
 
 PresenterFrameworkObserver::PresenterFrameworkObserver (
     const css::uno::Reference<css::drawing::framework::XConfigurationController>&rxController,
-    const OUString& rsEventName,
     const Predicate& rPredicate,
     const Action& rAction)
     : PresenterFrameworkObserverInterfaceBase(m_aMutex),
@@ -42,13 +41,6 @@ PresenterFrameworkObserver::PresenterFrameworkObserver (
 
     if (mxConfigurationController->hasPendingRequests())
     {
-        if (!rsEventName.isEmpty())
-        {
-            mxConfigurationController->addConfigurationChangeListener(
-                this,
-                rsEventName,
-                Any());
-        }
         mxConfigurationController->addConfigurationChangeListener(
             this,
             "ConfigurationUpdateEnd",
@@ -70,7 +62,6 @@ void PresenterFrameworkObserver::RunOnUpdateEnd (
 {
     new PresenterFrameworkObserver(
         rxController,
-        OUString(),
         &PresenterFrameworkObserver::True,
         rAction);
 }
diff --git a/sdext/source/presenter/PresenterFrameworkObserver.hxx b/sdext/source/presenter/PresenterFrameworkObserver.hxx
index 3937606d7d80..33e8e4fff31d 100644
--- a/sdext/source/presenter/PresenterFrameworkObserver.hxx
+++ b/sdext/source/presenter/PresenterFrameworkObserver.hxx
@@ -62,10 +62,6 @@ private:
     Action maAction;
 
     /** Create a new PresenterFrameworkObserver object.
-        @param rsEventName
-            An event name other than ConfigurationUpdateEnd.  When the
-            observer shall only listen for ConfigurationUpdateEnd then pass
-            an empty name.
         @param rPredicate
             This functor tests whether the action is to be executed or not.
         @param rAction
@@ -74,7 +70,6 @@ private:
     */
     PresenterFrameworkObserver (
         const css::uno::Reference<css::drawing::framework::XConfigurationController>&rxController,
-        const OUString& rsEventName,
         const Predicate& rPredicate,
         const Action& rAction);
     virtual ~PresenterFrameworkObserver() override;
diff --git a/sdext/source/presenter/PresenterPaneBorderPainter.cxx b/sdext/source/presenter/PresenterPaneBorderPainter.cxx
index f35662ebebbc..249a435372dc 100644
--- a/sdext/source/presenter/PresenterPaneBorderPainter.cxx
+++ b/sdext/source/presenter/PresenterPaneBorderPainter.cxx
@@ -303,7 +303,7 @@ bool PresenterPaneBorderPainter::ProvideTheme (const Reference<rendering::XCanva
     }
     else
     {
-        mpTheme.reset(new PresenterTheme(mxContext, OUString(), rxCanvas));
+        mpTheme.reset(new PresenterTheme(mxContext, rxCanvas));
         bModified = true;
     }
 
diff --git a/sdext/source/presenter/PresenterPaneFactory.cxx b/sdext/source/presenter/PresenterPaneFactory.cxx
index a2a83d8cc27b..592277ff88b2 100644
--- a/sdext/source/presenter/PresenterPaneFactory.cxx
+++ b/sdext/source/presenter/PresenterPaneFactory.cxx
@@ -174,7 +174,7 @@ Reference<XResource> SAL_CALL PresenterPaneFactory::createResource (
     }
 
     // No.  Create a new one.
-    Reference<XResource> xResource = CreatePane(rxPaneId, OUString());
+    Reference<XResource> xResource = CreatePane(rxPaneId);
     return xResource;
 }
 
@@ -214,8 +214,7 @@ void SAL_CALL PresenterPaneFactory::releaseResource (const Reference<XResource>&
 
 
 Reference<XResource> PresenterPaneFactory::CreatePane (
-    const Reference<XResourceId>& rxPaneId,
-    const OUString& rsTitle)
+    const Reference<XResourceId>& rxPaneId)
 {
     if ( ! rxPaneId.is())
         return nullptr;
@@ -236,7 +235,7 @@ Reference<XResource> PresenterPaneFactory::CreatePane (
     {
         return CreatePane(
             rxPaneId,
-            rsTitle,
+            OUString(),
             xParentPane,
             rxPaneId->getFullResourceURL().Arguments == "Sprite=1");
     }
diff --git a/sdext/source/presenter/PresenterPaneFactory.hxx b/sdext/source/presenter/PresenterPaneFactory.hxx
index f605a0d8f59c..e1016d39fdfd 100644
--- a/sdext/source/presenter/PresenterPaneFactory.hxx
+++ b/sdext/source/presenter/PresenterPaneFactory.hxx
@@ -101,8 +101,7 @@ private:
     void Register (const css::uno::Reference<css::frame::XController>& rxController);
 
     css::uno::Reference<css::drawing::framework::XResource> CreatePane (
-        const css::uno::Reference<css::drawing::framework::XResourceId>& rxPaneId,
-        const OUString& rsTitle);
+        const css::uno::Reference<css::drawing::framework::XResourceId>& rxPaneId);
     css::uno::Reference<css::drawing::framework::XResource> CreatePane (
         const css::uno::Reference<css::drawing::framework::XResourceId>& rxPaneId,
         const OUString& rsTitle,
diff --git a/sdext/source/presenter/PresenterTheme.cxx b/sdext/source/presenter/PresenterTheme.cxx
index 881aa4e12e34..6ff144ffa14c 100644
--- a/sdext/source/presenter/PresenterTheme.cxx
+++ b/sdext/source/presenter/PresenterTheme.cxx
@@ -261,10 +261,8 @@ private:
 
 PresenterTheme::PresenterTheme (
     const css::uno::Reference<css::uno::XComponentContext>& rxContext,
-    const OUString& rsThemeName,
     const css::uno::Reference<css::rendering::XCanvas>& rxCanvas)
     : mxContext(rxContext),
-      msThemeName(rsThemeName),
       mpTheme(),
       mxCanvas(rxCanvas)
 {
diff --git a/sdext/source/presenter/PresenterTheme.hxx b/sdext/source/presenter/PresenterTheme.hxx
index e74c92fb4735..841f9782f900 100644
--- a/sdext/source/presenter/PresenterTheme.hxx
+++ b/sdext/source/presenter/PresenterTheme.hxx
@@ -60,7 +60,6 @@ class PresenterTheme
 public:
     PresenterTheme (
         const css::uno::Reference<css::uno::XComponentContext>& rxContext,
-        const OUString& rsThemeName,
         const css::uno::Reference<css::rendering::XCanvas>& rxCanvas);
     ~PresenterTheme();