diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-23 08:48:06 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-09-27 11:48:46 +0200 |
commit | 1534025a0386584a7b8f3f929b10ce5eb33257cf (patch) | |
tree | 7f12dd6763148089cd4fb5495c8fffe84f415e12 /sdext/source | |
parent | 0f2e01677cd0e8857faec99c61d71e88eee78b27 (diff) |
loplugin:methodcycles more graph theory for the win
implemeent a reduction approach, which is good at finding virtual
methods that only themselves or their virtual partners.
The accessibility GetVisArea stuff is dead since
commit 891e41fac81fbd8d5cdb277b26639abfd25a7143
Date: Wed Apr 4 11:23:22 2018 +0200
dead code in AccessibleTextHelper_Impl::UpdateVisibleChildren
Change-Id: I78d9d8bca585ecec8394f2c3fe2baa93db0e58f5
Reviewed-on: https://gerrit.libreoffice.org/60912
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sdext/source')
-rw-r--r-- | sdext/source/pdfimport/inc/genericelements.hxx | 1 | ||||
-rw-r--r-- | sdext/source/pdfimport/tree/genericelements.cxx | 30 |
2 files changed, 0 insertions, 31 deletions
diff --git a/sdext/source/pdfimport/inc/genericelements.hxx b/sdext/source/pdfimport/inc/genericelements.hxx index 59defa1588e7..416c02b36cc7 100644 --- a/sdext/source/pdfimport/inc/genericelements.hxx +++ b/sdext/source/pdfimport/inc/genericelements.hxx @@ -254,7 +254,6 @@ namespace pdfi virtual void visitedBy( ElementTreeVisitor&, const std::list< std::unique_ptr<Element> >::const_iterator& rParentIt ) override; - static void updateParagraphGeometry( Element* pEle ); void resolveHyperlinks(); void resolveFontStyles( PDFIProcessor const & rProc ); void resolveUnderlines( PDFIProcessor const & rProc ); diff --git a/sdext/source/pdfimport/tree/genericelements.cxx b/sdext/source/pdfimport/tree/genericelements.cxx index 410b371134a8..d4eb7dcc34d8 100644 --- a/sdext/source/pdfimport/tree/genericelements.cxx +++ b/sdext/source/pdfimport/tree/genericelements.cxx @@ -265,36 +265,6 @@ void PageElement::visitedBy( ElementTreeVisitor& rVisit rVisitor.visit(*this, rParentIt); } -void PageElement::updateParagraphGeometry( Element* pEle ) -{ - // update geometry of children - for( auto it = pEle->Children.begin(); - it != pEle->Children.end(); ++it ) - { - updateParagraphGeometry( it->get() ); - } - // if this is a paragraph itself, then update according to children geometry - if( dynamic_cast<ParagraphElement*>(pEle) ) - { - for( auto it = pEle->Children.begin(); - it != pEle->Children.end(); ++it ) - { - Element* pChild = nullptr; - TextElement* pText = dynamic_cast<TextElement*>(it->get()); - if( pText ) - pChild = pText; - else - { - ParagraphElement* pPara = dynamic_cast<ParagraphElement*>(it->get()); - if( pPara ) - pChild = pPara; - } - if( pChild ) - pEle->updateGeometryWith( pChild ); - } - } -} - bool PageElement::resolveHyperlink( const std::list<std::unique_ptr<Element>>::iterator& link_it, std::list<std::unique_ptr<Element>>& rElements ) { HyperlinkElement* pLink = dynamic_cast<HyperlinkElement*>(link_it->get()); |