diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-04 14:34:07 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-04-11 09:48:10 +0200 |
| commit | 49eb02f07a5af44da59008a238e828b4a9532bef (patch) | |
| tree | 43c4b4eaacd79fe0bff784a4ef71f4c1080c3912 /sdext | |
| parent | 5823ecd54b16974ffe8821a5ae061cd0ecc4cf84 (diff) | |
new loplugin:unusedvariablemore
collection of heuristics to look for local variables that are never read
from i.e. do not contribute to the surrounding logic
This is an expensive plugin, since it walks up the parent tree,
so it is off by default.
Change-Id: Ib8ba292241bd16adf299e8bba4502cb473513a06
Reviewed-on: https://gerrit.libreoffice.org/52450
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sdext')
| -rw-r--r-- | sdext/source/presenter/PresenterNotesView.cxx | 8 | ||||
| -rw-r--r-- | sdext/source/presenter/PresenterSlideSorter.cxx | 3 |
2 files changed, 1 insertions, 10 deletions
diff --git a/sdext/source/presenter/PresenterNotesView.cxx b/sdext/source/presenter/PresenterNotesView.cxx index 7ea54d85cc7c..3413d4349dfa 100644 --- a/sdext/source/presenter/PresenterNotesView.cxx +++ b/sdext/source/presenter/PresenterNotesView.cxx @@ -228,8 +228,6 @@ void PresenterNotesView::SetSlide (const Reference<drawing::XDrawPage>& rxNotesP Reference<container::XIndexAccess> xIndexAccess (rxNotesPage, UNO_QUERY); if (xIndexAccess.is()) { - OUString sText; - // Iterate over all shapes and find the one that holds the text. sal_Int32 nCount (xIndexAccess->getCount()); for (sal_Int32 nIndex=0; nIndex<nCount; ++nIndex) @@ -240,11 +238,6 @@ void PresenterNotesView::SetSlide (const Reference<drawing::XDrawPage>& rxNotesP if (xServiceName.is() && xServiceName->getServiceName() == sNotesShapeName) { - Reference<text::XTextRange> xText (xServiceName, UNO_QUERY); - if (xText.is()) - { - sText += xText->getString(); - } } else { @@ -259,7 +252,6 @@ void PresenterNotesView::SetSlide (const Reference<drawing::XDrawPage>& rxNotesP xIndexAccess->getByIndex(nIndex), UNO_QUERY); if (xText.is()) { - sText += xText->getString(); mpTextView->SetText(Reference<text::XText>(xText, UNO_QUERY)); } } diff --git a/sdext/source/presenter/PresenterSlideSorter.cxx b/sdext/source/presenter/PresenterSlideSorter.cxx index 805eb4053da0..cc1f98358a3b 100644 --- a/sdext/source/presenter/PresenterSlideSorter.cxx +++ b/sdext/source/presenter/PresenterSlideSorter.cxx @@ -643,7 +643,6 @@ void PresenterSlideSorter::UpdateLayout() mbIsLayoutPending = false; const awt::Rectangle aWindowBox (mxWindow->getPosSize()); - awt::Rectangle aCenterBox (aWindowBox); sal_Int32 nLeftBorderWidth (aWindowBox.X); // Get border width. @@ -661,7 +660,7 @@ void PresenterSlideSorter::UpdateLayout() pPane->mxPane->GetPaneBorderPainter()); if ( ! xBorderPainter.is()) break; - aCenterBox = xBorderPainter->addBorder ( + xBorderPainter->addBorder ( mxViewId->getAnchor()->getResourceURL(), awt::Rectangle(0, 0, aWindowBox.Width, aWindowBox.Height), drawing::framework::BorderType_INNER_BORDER); |