diff options
| author | Noel Grandin <noelgrandin@gmail.com> | 2015-06-13 22:15:31 +0200 |
|---|---|---|
| committer | Noel Grandin <noel@peralex.com> | 2015-06-15 14:46:41 +0200 |
| commit | 4729774b244db7a175077ed0c70aa48be62bc60e (patch) | |
| tree | 9f0f2e329d269835d4c20a8183a2772b734608f3 /sdext | |
| parent | 9db80b1499e09cde000160434728f7b231c30db8 (diff) | |
remove unnecessary check for null when calling delete
Idea originally from caolan.
Found using the following command:
find . -name *.cxx | xargs /opt/local/bin/grep -zlP '(?m)if\s*\(\s*\w+\s*\)\s*delete\s+\w+\;'
Change-Id: I3338f4e22193a6dfd6219c8c75835224a3392763
Diffstat (limited to 'sdext')
| -rw-r--r-- | sdext/source/pdfimport/pdfparse/pdfentries.cxx | 3 | ||||
| -rw-r--r-- | sdext/source/pdfimport/tree/genericelements.cxx | 6 |
2 files changed, 3 insertions, 6 deletions
diff --git a/sdext/source/pdfimport/pdfparse/pdfentries.cxx b/sdext/source/pdfimport/pdfparse/pdfentries.cxx index 9765086a333d..1f8cf7e7a32c 100644 --- a/sdext/source/pdfimport/pdfparse/pdfentries.cxx +++ b/sdext/source/pdfimport/pdfparse/pdfentries.cxx @@ -1054,8 +1054,7 @@ struct PDFFileImplData PDFFile::~PDFFile() { - if( m_pData ) - delete m_pData; + delete m_pData; } bool PDFFile::isEncrypted() const diff --git a/sdext/source/pdfimport/tree/genericelements.cxx b/sdext/source/pdfimport/tree/genericelements.cxx index 7332495fa66a..67d2767ccc63 100644 --- a/sdext/source/pdfimport/tree/genericelements.cxx +++ b/sdext/source/pdfimport/tree/genericelements.cxx @@ -266,10 +266,8 @@ TextElement* ParagraphElement::getFirstTextChild() const PageElement::~PageElement() { - if( HeaderElement ) - delete HeaderElement; - if( FooterElement ) - delete FooterElement; + delete HeaderElement; + delete FooterElement; } void PageElement::visitedBy( ElementTreeVisitor& rVisitor, |