loplugin:unusedmethods unused return value in sdext

Change-Id: Ie919a094630da57371b13081ab2f04984dd96c78

10 files changed, 14 insertions, 27 deletions

diff --git a/sdext/source/minimizer/impoptimizer.cxx b/sdext/source/minimizer/impoptimizer.cxx
index f2be9365ed66..710834707ffe 100644
--- a/sdext/source/minimizer/impoptimizer.cxx
+++ b/sdext/source/minimizer/impoptimizer.cxx
@@ -592,10 +592,8 @@ static void DispatchURL( Reference< XComponentContext > xContext, const OUString
 
 
 
-bool ImpOptimizer::Optimize( const Sequence< PropertyValue >& rArguments )
+void ImpOptimizer::Optimize( const Sequence< PropertyValue >& rArguments )
 {
-    bool bRet = true;
-
     if ( mxModel.is() )
     {
         sal_Int64 nEstimatedFileSize = 0;
@@ -692,7 +690,7 @@ bool ImpOptimizer::Optimize( const Sequence< PropertyValue >& rArguments )
         if ( xStorable.is() && !xStorable->isReadonly() )
         {
             mxModel->lockControllers();
-            bRet = Optimize();
+            Optimize();
             mxModel->unlockControllers();
 
             // clearing undo stack:
@@ -741,9 +739,6 @@ bool ImpOptimizer::Optimize( const Sequence< PropertyValue >& rArguments )
             DispatchStatus();
         }
     }
-    else
-        bRet = false;
-    return bRet;
 }
 
 /* vim:set shiftwidth=4 softtabstop=4 expandtab: */
diff --git a/sdext/source/minimizer/impoptimizer.hxx b/sdext/source/minimizer/impoptimizer.hxx
index 080fd10063f2..1b4a29e4f8d7 100644
--- a/sdext/source/minimizer/impoptimizer.hxx
+++ b/sdext/source/minimizer/impoptimizer.hxx
@@ -67,7 +67,7 @@ public:
             const css::uno::Reference< css::frame::XModel >& rxModel );
         ~ImpOptimizer();
 
-        bool     Optimize( const css::uno::Sequence< css::beans::PropertyValue >& rArguments );
+        void     Optimize( const css::uno::Sequence< css::beans::PropertyValue >& rArguments );
         void     DispatchStatus();
 };
 
diff --git a/sdext/source/minimizer/informationdialog.cxx b/sdext/source/minimizer/informationdialog.cxx
index fcb2e5c7e9c5..45733ba2dbad 100644
--- a/sdext/source/minimizer/informationdialog.cxx
+++ b/sdext/source/minimizer/informationdialog.cxx
@@ -338,7 +338,7 @@ InformationDialog::~InformationDialog()
 
 
 
-bool InformationDialog::execute()
+void InformationDialog::execute()
 {
     UnoDialog::execute();
 
@@ -352,7 +352,6 @@ bool InformationDialog::execute()
             mrbOpenNewDocument = bOpenNewDocument;
         }
     }
-    return mbStatus;
 }
 
 
diff --git a/sdext/source/minimizer/informationdialog.hxx b/sdext/source/minimizer/informationdialog.hxx
index ba60bb8e1515..163da92df607 100644
--- a/sdext/source/minimizer/informationdialog.hxx
+++ b/sdext/source/minimizer/informationdialog.hxx
@@ -52,7 +52,7 @@ public:
                 bool& bOpenNewDocument, const sal_Int64& nSourceSize, const sal_Int64& nDestSize, const sal_Int64& nApproxDest );
     ~InformationDialog();
 
-    bool                execute();
+    void                execute();
 
 private:
 
diff --git a/sdext/source/minimizer/optimizerdialog.cxx b/sdext/source/minimizer/optimizerdialog.cxx
index 2de2347e91b8..db3b535e37b4 100644
--- a/sdext/source/minimizer/optimizerdialog.cxx
+++ b/sdext/source/minimizer/optimizerdialog.cxx
@@ -249,14 +249,13 @@ OptimizerDialog::~OptimizerDialog()
 
 
 
-bool OptimizerDialog::execute()
+void OptimizerDialog::execute()
 {
     Reference< XItemEventBroadcaster > maRoadmapBroadcaster( mxRoadmapControl, UNO_QUERY_THROW );
     maRoadmapBroadcaster->addItemListener( mxItemListener );
     UnoDialog::execute();
     UpdateConfiguration();          // taking actual control settings for the configuration
     maRoadmapBroadcaster->removeItemListener( mxItemListener );
-    return mbStatus;
 }
 
 
diff --git a/sdext/source/minimizer/optimizerdialog.hxx b/sdext/source/minimizer/optimizerdialog.hxx
index 6f6542684d15..789df68e58ee 100644
--- a/sdext/source/minimizer/optimizerdialog.hxx
+++ b/sdext/source/minimizer/optimizerdialog.hxx
@@ -65,7 +65,7 @@ public:
         css::uno::Reference< css::frame::XDispatch > rxStatusDispatcher );
     ~OptimizerDialog();
 
-    bool                execute();
+    void                execute();
 
     sal_Int16               mnCurrentStep;
     sal_Int16               mnTabIndex;
diff --git a/sdext/source/pdfimport/inc/pdfparse.hxx b/sdext/source/pdfimport/inc/pdfparse.hxx
index 888e6e65774b..037714ba1fca 100644
--- a/sdext/source/pdfimport/inc/pdfparse.hxx
+++ b/sdext/source/pdfimport/inc/pdfparse.hxx
@@ -273,7 +273,7 @@ struct PDFObject : public PDFContainer
     virtual PDFEntry* clone() const override;
 
     // writes only the contained stream, deflated if necessary
-    bool writeStream( EmitContext& rContext, const PDFFile* pPDFFile ) const;
+    void writeStream( EmitContext& rContext, const PDFFile* pPDFFile ) const;
 
 private:
     // returns true if stream is deflated
diff --git a/sdext/source/pdfimport/pdfparse/pdfentries.cxx b/sdext/source/pdfimport/pdfparse/pdfentries.cxx
index 67fbc026043d..7ccd8e253ada 100644
--- a/sdext/source/pdfimport/pdfparse/pdfentries.cxx
+++ b/sdext/source/pdfimport/pdfparse/pdfentries.cxx
@@ -74,11 +74,11 @@ struct EmitImplData
         m_nDecryptGeneration( 0 )
     {}
     ~EmitImplData() {}
-    bool decrypt( const sal_uInt8* pInBuffer, sal_uInt32 nLen, sal_uInt8* pOutBuffer,
+    void decrypt( const sal_uInt8* pInBuffer, sal_uInt32 nLen, sal_uInt8* pOutBuffer,
                   unsigned int nObject, unsigned int nGeneration ) const
     {
         const PDFFile* pFile = dynamic_cast<const PDFFile*>(m_pObjectContainer);
-        return pFile && pFile->decrypt( pInBuffer, nLen, pOutBuffer, nObject, nGeneration );
+        pFile && pFile->decrypt( pInBuffer, nLen, pOutBuffer, nObject, nGeneration );
     }
 
     void setDecryptObject( unsigned int nObject, unsigned int nGeneration )
@@ -769,9 +769,8 @@ static void unzipToBuffer( char* pBegin, unsigned int nLen,
     }
 }
 
-bool PDFObject::writeStream( EmitContext& rWriteContext, const PDFFile* pParsedFile ) const
+void PDFObject::writeStream( EmitContext& rWriteContext, const PDFFile* pParsedFile ) const
 {
-    bool bSuccess = false;
     if( m_pStream )
     {
         char* pStream = nullptr;
@@ -788,7 +787,6 @@ bool PDFObject::writeStream( EmitContext& rWriteContext, const PDFFile* pParsedF
             rWriteContext.write( pStream, nBytes );
         rtl_freeMemory( pStream );
     }
-    return bSuccess;
 }
 
 bool PDFObject::emit( EmitContext& rWriteContext ) const
diff --git a/sdext/source/presenter/PresenterPaneBorderPainter.cxx b/sdext/source/presenter/PresenterPaneBorderPainter.cxx
index 6a08ed838d9f..07bbc49e9b3e 100644
--- a/sdext/source/presenter/PresenterPaneBorderPainter.cxx
+++ b/sdext/source/presenter/PresenterPaneBorderPainter.cxx
@@ -326,19 +326,15 @@ bool PresenterPaneBorderPainter::ProvideTheme (const Reference<rendering::XCanva
     return bModified;
 }
 
-bool PresenterPaneBorderPainter::ProvideTheme()
+void PresenterPaneBorderPainter::ProvideTheme()
 {
     if (mpTheme.get() == nullptr)
     {
         // Create a theme without bitmaps (no canvas => no bitmaps).
-        return ProvideTheme(nullptr);
+        ProvideTheme(nullptr);
     }
-    else
-    {
         // When there already is a theme then without a canvas we can not
         // add anything new.
-        return false;
-    }
 }
 
 void PresenterPaneBorderPainter::SetTheme (const std::shared_ptr<PresenterTheme>& rpTheme)
diff --git a/sdext/source/presenter/PresenterPaneBorderPainter.hxx b/sdext/source/presenter/PresenterPaneBorderPainter.hxx
index a89103091be4..324f7e911821 100644
--- a/sdext/source/presenter/PresenterPaneBorderPainter.hxx
+++ b/sdext/source/presenter/PresenterPaneBorderPainter.hxx
@@ -135,7 +135,7 @@ private:
     */
     bool ProvideTheme (
         const css::uno::Reference<css::rendering::XCanvas>& rxCanvas);
-    bool ProvideTheme();
+    void ProvideTheme();
 
     void ThrowIfDisposed() const
         throw (css::lang::DisposedException);