diff options
| author | Stephan Bergmann <sbergman@redhat.com> | 2018-09-18 17:25:55 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2018-09-18 23:18:01 +0200 |
| commit | 28b4f4aeaf160c7721dfecf5bd2445d7dbc6f01c (patch) | |
| tree | c281b491f1792d1a509294904911811324093e41 /setup_native/source/win32/customactions/shellextensions/checkpatches.cxx | |
| parent | b9a2d00c7c38ccd24b0663a2ecc6c08106fe51f1 (diff) | |
Get rid of Windows .def files in setup_native, use __declspec(dllexport)
For one, replacing the dated .def files with equivalent functionality should be
a good move all by itself. And for another, it paves the way for using
loplugin:external with clang-cl on Windows, which uses the heuristic of not
warning about functions that are explicitly marked as __declspec(dllexport).
Change-Id: I6efd50a8c5ce2a166ca0dd4e5f472118f3f9a071
Reviewed-on: https://gerrit.libreoffice.org/60691
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'setup_native/source/win32/customactions/shellextensions/checkpatches.cxx')
| -rw-r--r-- | setup_native/source/win32/customactions/shellextensions/checkpatches.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/setup_native/source/win32/customactions/shellextensions/checkpatches.cxx b/setup_native/source/win32/customactions/shellextensions/checkpatches.cxx index 729bce0bc0cb..836b3e655e75 100644 --- a/setup_native/source/win32/customactions/shellextensions/checkpatches.cxx +++ b/setup_native/source/win32/customactions/shellextensions/checkpatches.cxx @@ -38,7 +38,7 @@ static inline void OutputDebugStringFormatW( PCWSTR, ... ) } #endif -extern "C" UINT __stdcall CheckPatchList( MSIHANDLE handle ) +extern "C" __declspec(dllexport) UINT __stdcall CheckPatchList( MSIHANDLE handle ) { std::wstring sPatchList = GetMsiPropertyW( handle, L"PATCH" ); std::wstring sRequiredPatch = GetMsiPropertyW( handle, L"PREREQUIREDPATCH" ); |