diff options
| author | kubak <kuba@openoffice.com.pl> | 2024-04-23 23:45:54 +0200 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2024-04-26 13:11:34 +0200 |
| commit | 8a24efd16d1515ff806406d37d234e4ac7940c45 (patch) | |
| tree | 46292357bff6d8dc5c5259d4962536946fd95562 /setup_native | |
| parent | 546741148863ae0b2a25cc994a7323c8113cb573 (diff) | |
MSI: Fix use of illegal character in table Binary
ICE03 ERROR Invalid identifier; Table: Binary, Column: Name, Key(s): Windows61-KB2999226-x64msu
ICE03 ERROR Invalid identifier; Table: Binary, Column: Name, Key(s): Windows81-KB2999226-x64msu
ICE03 ERROR Invalid identifier; Table: Binary, Column: Name, Key(s): Windows8-RT-KB2999226-x64msu
We use the illegal "-" character.
https: //learn.microsoft.com/en-us/windows/win32/msi/binary-table
https: //learn.microsoft.com/en-us/windows/win32/msi/identifier
Change-Id: I44aea358964c085599ab42f134535fa97840dd26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/166567
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'setup_native')
| -rw-r--r-- | setup_native/source/win32/customactions/inst_msu/inst_msu.cxx | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx b/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx index 8adffbba6228..d890f2628193 100644 --- a/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx +++ b/setup_native/source/win32/customactions/inst_msu/inst_msu.cxx @@ -456,7 +456,7 @@ extern "C" __declspec(dllexport) UINT __stdcall UnpackMSUForInstall(MSIHANDLE hI CheckWin32Error("MsiGetPropertyW", MsiGetPropertyW(hInstall, L"InstMSUBinary", sInstMSUBinary, &nCCh)); WriteLog(hInstall, "Got InstMSUBinary value:", - sInstMSUBinary); // KB2999226|Windows61-KB2999226-x64msu + sInstMSUBinary); // KB2999226|Windows61_KB2999226_x64msu const wchar_t* sBinaryName = wcschr(sInstMSUBinary, L'|'); if (!sBinaryName) throw std::exception("No KB number in InstMSUBinary!"); |