clang-tidy modernize-pass-by-value in sfx2

Change-Id: I7984f0b52809091511dc01005fdbfeafd521b4bf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/137048
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

11 files changed, 14 insertions, 14 deletions

diff --git a/sfx2/inc/commandpopup/CommandPopup.hxx b/sfx2/inc/commandpopup/CommandPopup.hxx
index a34425f0d693..c93a283608c3 100644
--- a/sfx2/inc/commandpopup/CommandPopup.hxx
+++ b/sfx2/inc/commandpopup/CommandPopup.hxx
@@ -9,6 +9,7 @@
 
 #pragma once
 
+#include <utility>
 #include <vcl/weld.hxx>
 
 #include <com/sun/star/uno/XComponentContext.hpp>
@@ -25,9 +26,9 @@ struct CurrentEntry final
     OUString m_aCommandURL;
     OUString m_aTooltip;
 
-    CurrentEntry(OUString const& rCommandURL, OUString const& rTooltip)
-        : m_aCommandURL(rCommandURL)
-        , m_aTooltip(rTooltip)
+    CurrentEntry(OUString aCommandURL, OUString aTooltip)
+        : m_aCommandURL(std::move(aCommandURL))
+        , m_aTooltip(std::move(aTooltip))
     {
     }
 };
diff --git a/sfx2/inc/preventduplicateinteraction.hxx b/sfx2/inc/preventduplicateinteraction.hxx
index 62e59dd96c2e..1798dd5f5bd4 100644
--- a/sfx2/inc/preventduplicateinteraction.hxx
+++ b/sfx2/inc/preventduplicateinteraction.hxx
@@ -252,7 +252,7 @@ class PreventDuplicateInteraction final :
 
             @threadsafe not necessary
         */
-        PreventDuplicateInteraction(const css::uno::Reference< css::uno::XComponentContext >& rxContext);
+        PreventDuplicateInteraction(css::uno::Reference< css::uno::XComponentContext > xContext);
 
 
         /**
diff --git a/sfx2/inc/saveastemplatedlg.hxx b/sfx2/inc/saveastemplatedlg.hxx
index a4df61853aaf..ddc95abd31c7 100644
--- a/sfx2/inc/saveastemplatedlg.hxx
+++ b/sfx2/inc/saveastemplatedlg.hxx
@@ -49,8 +49,7 @@ public:
     bool SaveTemplate();
 
 public:
-    SfxSaveAsTemplateDialog(weld::Window* pParent,
-                            const css::uno::Reference<css::frame::XModel>& rModel);
+    SfxSaveAsTemplateDialog(weld::Window* pParent, css::uno::Reference<css::frame::XModel> xModel);
 };
 
 #endif // INCLUDED_SFX2_INC_SAVEASTEMPLATEDLG_HXX
diff --git a/sfx2/inc/sidebar/DeckTitleBar.hxx b/sfx2/inc/sidebar/DeckTitleBar.hxx
index 7ed23a8bf914..72eda5cb7d7b 100644
--- a/sfx2/inc/sidebar/DeckTitleBar.hxx
+++ b/sfx2/inc/sidebar/DeckTitleBar.hxx
@@ -30,7 +30,7 @@ class DeckTitleBar final : public TitleBar
 {
 public:
     DeckTitleBar(const OUString& rsTitle, weld::Builder& rBuilder,
-                 const std::function<void()>& rCloserAction);
+                 std::function<void()> aCloserAction);
     virtual ~DeckTitleBar() override;
 
     virtual void SetTitle(const OUString& rsTitle) override;
diff --git a/sfx2/inc/sidebar/UnoDeck.hxx b/sfx2/inc/sidebar/UnoDeck.hxx
index 42c975c44d3b..b65042355419 100644
--- a/sfx2/inc/sidebar/UnoDeck.hxx
+++ b/sfx2/inc/sidebar/UnoDeck.hxx
@@ -28,7 +28,7 @@ class SfxUnoDeck final : public cppu::WeakImplHelper<css::ui::XDeck>
 
 public:
 
-    SfxUnoDeck(const css::uno::Reference<css::frame::XFrame>& , const OUString&);
+    SfxUnoDeck(css::uno::Reference<css::frame::XFrame>, OUString );
 
     virtual OUString SAL_CALL getId() override;
 
diff --git a/sfx2/inc/sidebar/UnoDecks.hxx b/sfx2/inc/sidebar/UnoDecks.hxx
index 95ce0be62398..ed7b50679006 100644
--- a/sfx2/inc/sidebar/UnoDecks.hxx
+++ b/sfx2/inc/sidebar/UnoDecks.hxx
@@ -24,7 +24,7 @@ class SfxUnoDecks final : public cppu::WeakImplHelper<css::ui::XDecks>
 
 public:
 
-    SfxUnoDecks(const css::uno::Reference<css::frame::XFrame>&);
+    SfxUnoDecks(css::uno::Reference<css::frame::XFrame> );
 
 // XNameAccess
 
diff --git a/sfx2/inc/sidebar/UnoPanel.hxx b/sfx2/inc/sidebar/UnoPanel.hxx
index 4e148befdf8d..97cd6c910c26 100644
--- a/sfx2/inc/sidebar/UnoPanel.hxx
+++ b/sfx2/inc/sidebar/UnoPanel.hxx
@@ -31,7 +31,7 @@ class SfxUnoPanel final : public cppu::WeakImplHelper<css::ui::XPanel>
 
 public:
 
-    SfxUnoPanel(const css::uno::Reference<css::frame::XFrame>& , const OUString&, const OUString&);
+    SfxUnoPanel(css::uno::Reference<css::frame::XFrame>, OUString, OUString );
 
     virtual OUString SAL_CALL getId() override;
 
diff --git a/sfx2/inc/sidebar/UnoPanels.hxx b/sfx2/inc/sidebar/UnoPanels.hxx
index 487043dee3f3..36b98c8c50c1 100644
--- a/sfx2/inc/sidebar/UnoPanels.hxx
+++ b/sfx2/inc/sidebar/UnoPanels.hxx
@@ -23,7 +23,7 @@ class SfxUnoPanels final : public cppu::WeakImplHelper<css::ui::XPanels>
 
 public:
 
-    SfxUnoPanels(const css::uno::Reference<css::frame::XFrame>& , const OUString&);
+    SfxUnoPanels(css::uno::Reference<css::frame::XFrame>, const OUString&);
 
 // XPanels
     virtual OUString SAL_CALL getDeckId() override;
diff --git a/sfx2/inc/sidebar/UnoSidebar.hxx b/sfx2/inc/sidebar/UnoSidebar.hxx
index 20ffa22b19bd..f1b5fffc7136 100644
--- a/sfx2/inc/sidebar/UnoSidebar.hxx
+++ b/sfx2/inc/sidebar/UnoSidebar.hxx
@@ -32,7 +32,7 @@ private:
 
 public:
 
-    SfxUnoSidebar(const css::uno::Reference<css::frame::XFrame>&);
+    SfxUnoSidebar(css::uno::Reference<css::frame::XFrame> );
 
     virtual void SAL_CALL showDecks (const sal_Bool bVisible) override;
 
diff --git a/sfx2/inc/srchdlg.hxx b/sfx2/inc/srchdlg.hxx
index 3d8317477ec0..e5a675e99fdd 100644
--- a/sfx2/inc/srchdlg.hxx
+++ b/sfx2/inc/srchdlg.hxx
@@ -48,7 +48,7 @@ private:
     DECL_LINK(FindHdl, weld::Button&, void);
 
 public:
-    SearchDialog(weld::Window* pWindow, const OUString& rConfigName);
+    SearchDialog(weld::Window* pWindow, OUString aConfigName);
     static void runAsync(const std::shared_ptr<SearchDialog>& rController);
     virtual ~SearchDialog() override;
 
diff --git a/sfx2/inc/unoctitm.hxx b/sfx2/inc/unoctitm.hxx
index 5dc93943f7d7..812dbce7077d 100644
--- a/sfx2/inc/unoctitm.hxx
+++ b/sfx2/inc/unoctitm.hxx
@@ -129,7 +129,7 @@ public:
                                                     SfxBindings*                       pBind,
                                                     SfxDispatcher*                     pDispat,
                                                     const SfxSlot*                     pSlot,
-                                                    const css::util::URL& rURL );
+                                                    css::util::URL aURL );
                         virtual ~SfxDispatchController_Impl() override;
 
     virtual void Notify(SfxBroadcaster& rBC, const SfxHint& rHint) override;