diff options
| author | dipanshu124 <dipanshu@iitk.ac.in> | 2021-03-02 14:53:31 +0530 |
|---|---|---|
| committer | Mike Kaganski <mike.kaganski@collabora.com> | 2021-03-14 20:24:09 +0100 |
| commit | 993298cfff01e09142c98faf03c3dbb608369114 (patch) | |
| tree | 7ce059f0a2b05f97d13c1192535f61580b6a4894 /sfx2/qa | |
| parent | 75e9b6bcfb515f7b03a357c077b6fa144f7669c3 (diff) | |
tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktop
MacrosTest::loadFromDesktop itself asserts on its return value. Thus,
there additional checks in unit tests are redundant.
Change-Id: Iec9be2293c6337fa747c78a0963e31aa99b60772
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111810
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Diffstat (limited to 'sfx2/qa')
| -rw-r--r-- | sfx2/qa/cppunit/test_misc.cxx | 3 |
1 files changed, 0 insertions, 3 deletions
diff --git a/sfx2/qa/cppunit/test_misc.cxx b/sfx2/qa/cppunit/test_misc.cxx index 02c2ed356f88..eea95d93f92e 100644 --- a/sfx2/qa/cppunit/test_misc.cxx +++ b/sfx2/qa/cppunit/test_misc.cxx @@ -106,7 +106,6 @@ CPPUNIT_TEST_FIXTURE(MiscTest, testNoThumbnail) const OUString aURL(m_directories.getURLFromSrc(u"/sfx2/qa/cppunit/misc/hello.odt")); uno::Reference<lang::XComponent> xComponent = loadFromDesktop(aURL, "com.sun.star.text.TextDocument"); - CPPUNIT_ASSERT(xComponent.is()); // Save it with the NoThumbnail option and assert that it has no thumbnail. #ifndef _WIN32 @@ -167,7 +166,6 @@ CPPUNIT_TEST_FIXTURE(MiscTest, testHardLinks) CPPUNIT_ASSERT_EQUAL(0, nRet); uno::Reference<lang::XComponent> xComponent = loadFromDesktop(aURL, "com.sun.star.text.TextDocument"); - CPPUNIT_ASSERT(xComponent.is()); uno::Reference<frame::XStorable> xStorable(xComponent, uno::UNO_QUERY); xStorable->store(); @@ -201,7 +199,6 @@ CPPUNIT_TEST_FIXTURE(MiscTest, testOverwrite) aTempFile.EnableKillingFile(); uno::Reference<lang::XComponent> xComponent = loadFromDesktop(aTempFile.GetURL(), "com.sun.star.text.TextDocument"); - CPPUNIT_ASSERT(xComponent.is()); uno::Reference<frame::XStorable> xStorable(xComponent, uno::UNO_QUERY); CPPUNIT_ASSERT(xStorable.is()); |