summaryrefslogtreecommitdiff
path: root/sfx2/qa
diff options
context:
space:
mode:
authorXisco Fauli <xiscofauli@libreoffice.org>2021-06-29 11:35:20 +0200
committerXisco Fauli <xiscofauli@libreoffice.org>2021-06-29 13:26:30 +0200
commit8fe4a2cb1ad3b4819e069179cc11430c5127613c (patch)
treef8265029a84d6a97b9abbe90ab66599749892fa0 /sfx2/qa
parent8b961addb7887a8b8dc8dbc6758c3dc7c1068ac4 (diff)
uitest: guard remaining execute_dialog_through_command
Mostly done with a script for motivation, see 89aaa17a0a4413f07da2bc5084b0164f15dc01ac < UITest: introduce guarded context managers > Change-Id: Ib8e7c5f5e2c9b8a7756fe533ea4f30349dd68761 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118076 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Diffstat (limited to 'sfx2/qa')
-rw-r--r--sfx2/qa/uitest/doc/objserv.py11
1 files changed, 4 insertions, 7 deletions
diff --git a/sfx2/qa/uitest/doc/objserv.py b/sfx2/qa/uitest/doc/objserv.py
index 7c658be8dfd8..67c4765d4840 100644
--- a/sfx2/qa/uitest/doc/objserv.py
+++ b/sfx2/qa/uitest/doc/objserv.py
@@ -14,14 +14,11 @@ class Test(UITestCase):
def testPdfSigning(self):
# Start Impress.
with self.ui_test.load_file(get_url_for_data_file("pdf-sign.pdf")) as impress_doc:
- doc = self.xUITest.getTopFocusWindow()
# Now use File -> Digital signatures -> Digital signatures.
- self.ui_test.execute_dialog_through_command(".uno:Signature")
- xDialog = self.xUITest.getTopFocusWindow()
- # Without the accompanying fix in place, this test would have failed with:
- # uno.com.sun.star.uno.RuntimeException: Could not find child with id: close vcl/source/uitest/uiobject.cxx:452
- self.ui_test.close_dialog_through_button(xDialog.getChild("close"))
-
+ with self.ui_test.execute_dialog_through_command_guarded(".uno:Signature", close_button="close"):
+ # Without the accompanying fix in place, this test would have failed with:
+ # uno.com.sun.star.uno.RuntimeException: Could not find child with id: close vcl/source/uitest/uiobject.cxx:452
+ pass
# vim: set shiftwidth=4 softtabstop=4 expandtab: