match original intent of String::Erase(String::Search))

the single argument String::Erase erased from the passed in index to the end of
the string

Search returns STRING_NOTFOUND on failure, which results in String::Erase
erasing nothing and so leaving the original string untouched.

Change-Id: I83939fce2a92c38fbfb62196b7248908117c1e69

1 files changed, 2 insertions, 4 deletions

diff --git a/sfx2/source/appl/appdde.cxx b/sfx2/source/appl/appdde.cxx
index cf9a7394aa58..f3efec169948 100644
--- a/sfx2/source/appl/appdde.cxx
+++ b/sfx2/source/appl/appdde.cxx
@@ -122,15 +122,13 @@ bool ImplDdeService::MakeTopic( const OUString& rNm )
     // First only loop over the ObjectShells to find those
     // with the specific name:
     sal_Bool bRet = sal_False;
-    OUString sNm( rNm );
-    sNm = sNm.toAsciiLowerCase();
+    OUString sNm( rNm.toAsciiLowerCase() );
     TypeId aType( TYPE(SfxObjectShell) );
     SfxObjectShell* pShell = SfxObjectShell::GetFirst( &aType );
     while( pShell )
     {
         OUString sTmp( pShell->GetTitle(SFX_TITLE_FULLNAME) );
-        sTmp = sTmp.toAsciiLowerCase();
-        if( sTmp == sNm )
+        if( sNm == sTmp.toAsciiLowerCase() )
         {
             SFX_APP()->AddDdeTopic( pShell );
             bRet = true;