diff options
| author | Noel <noelgrandin@gmail.com> | 2020-11-18 10:10:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2020-11-24 09:45:04 +0100 |
| commit | bb06f51308428500c9c8d11ae05f0aa03ecc179c (patch) | |
| tree | b18620e8572ed6d4c43c8605660d59f5f7a7e531 /sfx2/source/dialog | |
| parent | 42e8e16cf93dcf944e5c1106f76aaa32057c0397 (diff) | |
loplugin:stringviewparam extend to comparison operators
which means that some call sites have to change to use
unicode string literals i.e. u"foo" instead of "foo"
Change-Id: Ie51c3adf56d343dd1d1710777f9d2a43ee66221c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sfx2/source/dialog')
| -rw-r--r-- | sfx2/source/dialog/filedlghelper.cxx | 4 | ||||
| -rw-r--r-- | sfx2/source/dialog/filedlgimpl.hxx | 4 | ||||
| -rw-r--r-- | sfx2/source/dialog/infobar.cxx | 4 | ||||
| -rw-r--r-- | sfx2/source/dialog/templdlg.cxx | 2 |
4 files changed, 7 insertions, 7 deletions
diff --git a/sfx2/source/dialog/filedlghelper.cxx b/sfx2/source/dialog/filedlghelper.cxx index bfc4c893b739..7c86ca18b98d 100644 --- a/sfx2/source/dialog/filedlghelper.cxx +++ b/sfx2/source/dialog/filedlghelper.cxx @@ -2218,7 +2218,7 @@ void FileDialogHelper_Impl::addFilterPair( const OUString& rFilter, } -OUString FileDialogHelper_Impl::getFilterName( const OUString& rFilterWithExtension ) const +OUString FileDialogHelper_Impl::getFilterName( std::u16string_view rFilterWithExtension ) const { OUString sRet; for (auto const& filter : maFilters) @@ -2232,7 +2232,7 @@ OUString FileDialogHelper_Impl::getFilterName( const OUString& rFilterWithExtens return sRet; } -OUString FileDialogHelper_Impl::getFilterWithExtension( const OUString& rFilter ) const +OUString FileDialogHelper_Impl::getFilterWithExtension( std::u16string_view rFilter ) const { OUString sRet; for (auto const& filter : maFilters) diff --git a/sfx2/source/dialog/filedlgimpl.hxx b/sfx2/source/dialog/filedlgimpl.hxx index c755bcc9f26f..e5e02e209748 100644 --- a/sfx2/source/dialog/filedlgimpl.hxx +++ b/sfx2/source/dialog/filedlgimpl.hxx @@ -200,8 +200,8 @@ namespace sfx2 bool isShowFilterExtensionEnabled() const; void addFilterPair( const OUString& rFilter, const OUString& rFilterWithExtension ); - OUString getFilterName( const OUString& rFilterWithExtension ) const; - OUString getFilterWithExtension( const OUString& rFilter ) const; + OUString getFilterName( std::u16string_view rFilterWithExtension ) const; + OUString getFilterWithExtension( std::u16string_view rFilter ) const; void SetContext( FileDialogHelper::Context _eNewContext ); diff --git a/sfx2/source/dialog/infobar.cxx b/sfx2/source/dialog/infobar.cxx index e8b176763c56..d46eb8f01440 100644 --- a/sfx2/source/dialog/infobar.cxx +++ b/sfx2/source/dialog/infobar.cxx @@ -399,7 +399,7 @@ VclPtr<SfxInfoBarWindow> SfxInfoBarContainerWindow::appendInfoBar(const OUString return pInfoBar; } -VclPtr<SfxInfoBarWindow> SfxInfoBarContainerWindow::getInfoBar(const OUString& sId) +VclPtr<SfxInfoBarWindow> SfxInfoBarContainerWindow::getInfoBar(std::u16string_view sId) { for (auto const& infoBar : m_pInfoBars) { @@ -409,7 +409,7 @@ VclPtr<SfxInfoBarWindow> SfxInfoBarContainerWindow::getInfoBar(const OUString& s return nullptr; } -bool SfxInfoBarContainerWindow::hasInfoBarWithID(const OUString& sId) +bool SfxInfoBarContainerWindow::hasInfoBarWithID(std::u16string_view sId) { return (getInfoBar(sId) != nullptr); } diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx index d9577bc852e3..182c20296d9e 100644 --- a/sfx2/source/dialog/templdlg.cxx +++ b/sfx2/source/dialog/templdlg.cxx @@ -475,7 +475,7 @@ static void MakeTree_Impl(StyleTreeArr_Impl& rArr, const OUString& aUIName) } static bool IsExpanded_Impl( const std::vector<OUString>& rEntries, - const OUString &rStr) + std::u16string_view rStr) { for (const auto & rEntry : rEntries) { |