new loplugin: change virtual methods to non-virtual

Where we can prove that the virtual method is never overriden.

In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.

Change-Id: I138ef81c95f115dbd8c023a83cfc7e9d5d6d14ae

2 files changed, 13 insertions, 13 deletions

diff --git a/sfx2/source/inc/templdgi.hxx b/sfx2/source/inc/templdgi.hxx
index fa7a26b90964..b7219a30ccba 100644
--- a/sfx2/source/inc/templdgi.hxx
+++ b/sfx2/source/inc/templdgi.hxx
@@ -208,8 +208,8 @@ protected:
     virtual void        CheckItem( sal_uInt16 /*nMesId*/, bool /*bCheck*/ = true ) {}
     virtual bool        IsCheckedItem( sal_uInt16 /*nMesId*/ ) { return true; }
     virtual void        LoadedFamilies() {}
-    virtual void        Update() { UpdateStyles_Impl(UPDATE_FAMILY_LIST); }
-    virtual void        InvalidateBindings();
+    void        Update() { UpdateStyles_Impl(UPDATE_FAMILY_LIST); }
+    void        InvalidateBindings();
     virtual void        InsertFamilyItem( sal_uInt16 nId, const SfxStyleFamilyItem* pIten ) = 0;
     virtual void        EnableFamilyItem( sal_uInt16 nId, bool bEnabled = true ) = 0;
     virtual void        ClearFamilyList() = 0;
@@ -267,10 +267,10 @@ public:
     DECL_LINK( MenuSelectHdl, Menu * );
 
     virtual void        EnableEdit( bool b = true ) { bCanEdit = b; }
-    virtual void        EnableDel( bool b = true )  { bCanDel = b; }
-    virtual void        EnableNew( bool b = true )  { bCanNew = b; }
-    virtual void        EnableHide( bool b = true )  { bCanHide = b; }
-    virtual void        EnableShow( bool b = true )  { bCanShow = b; }
+    void        EnableDel( bool b = true )  { bCanDel = b; }
+    void        EnableNew( bool b = true )  { bCanNew = b; }
+    void        EnableHide( bool b = true )  { bCanHide = b; }
+    void        EnableShow( bool b = true )  { bCanShow = b; }
 
     vcl::Window*             GetWindow() { return pWindow; }
 
@@ -281,7 +281,7 @@ public:
     OUString            GetSelectedEntry() const;
     SfxObjectShell*     GetObjectShell() const { return pCurObjShell; }
 
-    virtual void        PrepareDeleteAction();  // disable buttons, change button text, etc. when del is going to happen
+    void        PrepareDeleteAction();  // disable buttons, change button text, etc. when del is going to happen
 
     inline bool         CanEdit( void ) const   { return bCanEdit; }
     inline bool         CanDel( void ) const    { return bCanDel; }
@@ -290,7 +290,7 @@ public:
     inline bool         CanShow( void ) const    { return bCanShow; }
 
     // normally for derivates from SvTreeListBoxes, but in this case the dialog handles context menus
-    virtual PopupMenu*  CreateContextMenu( void );
+    PopupMenu*  CreateContextMenu( void );
 };
 
 class DropToolBox_Impl : public ToolBox, public DropTargetHelper
@@ -323,7 +323,7 @@ private:
     DECL_LINK( MenuSelectHdl, Menu* );
 
 protected:
-    virtual void    Command( const CommandEvent& rMEvt );
+    void    Command( const CommandEvent& rMEvt );
     virtual void    EnableEdit( bool = true ) SAL_OVERRIDE;
     virtual void    EnableItem( sal_uInt16 nMesId, bool bCheck = true ) SAL_OVERRIDE;
     virtual void    CheckItem( sal_uInt16 nMesId, bool bCheck = true ) SAL_OVERRIDE;
diff --git a/sfx2/source/inc/workwin.hxx b/sfx2/source/inc/workwin.hxx
index db58c1a54670..3d20a0e1dc31 100644
--- a/sfx2/source/inc/workwin.hxx
+++ b/sfx2/source/inc/workwin.hxx
@@ -242,10 +242,10 @@ protected:
     void                    RemoveChildWin_Impl(SfxChildWin_Impl*);
     void                    Sort_Impl();
     SfxChild_Impl*          FindChild_Impl( const vcl::Window& rWindow ) const;
-    virtual bool            RequestTopToolSpacePixel_Impl( SvBorder aBorder );
+    bool            RequestTopToolSpacePixel_Impl( SvBorder aBorder );
     virtual Rectangle       GetTopRect_Impl();
     SvBorder                Arrange_Impl();
-    virtual void            SaveStatus_Impl(SfxChildWindow*, const SfxChildWinInfo&);
+    void            SaveStatus_Impl(SfxChildWindow*, const SfxChildWinInfo&);
     static bool         IsPluginMode( SfxObjectShell* pObjShell );
 
 public:
@@ -308,13 +308,13 @@ public:
     void                    ShowChildWindow_Impl(sal_uInt16, bool bVisible, bool bSetFocus);
     void                    SetChildWindow_Impl(sal_uInt16, bool bOn, bool bSetFocus);
     SfxChildWindow*         GetChildWindow_Impl(sal_uInt16);
-    virtual void            InitializeChild_Impl(SfxChildWin_Impl*);
+    void            InitializeChild_Impl(SfxChildWin_Impl*);
     SfxSplitWindow*         GetSplitWindow_Impl(SfxChildAlignment);
 
     bool                    IsVisible_Impl( sal_uInt16 nMode ) const;
     bool                    IsFloating( sal_uInt16 nId );
     void                    SetActiveChild_Impl( vcl::Window *pChild );
-    virtual bool            ActivateNextChild_Impl( bool bForward = true );
+    bool            ActivateNextChild_Impl( bool bForward = true );
     bool                    AllowChildWindowCreation_Impl( const SfxChildWin_Impl& i_rCW ) const;
 
     // Methods for StatusBar