diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 08:37:40 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-10-26 11:20:07 +0200 |
| commit | c0cc59adca23580864a2e5cdadf66212246cbfcc (patch) | |
| tree | 57413c8efb3ca4a59f3699592353da1c575e345d /sfx2/source/view | |
| parent | 4bf2052e9dbdfcd32a749747c918f2d714010633 (diff) | |
loplugin:singlevalfields improvement
look for any kind of types, not just POD types, helps to find
smart pointer fields that are only assigned nullptr
Change-Id: I2d887e98db012f03b646e1023985bcc196285abc
Reviewed-on: https://gerrit.libreoffice.org/62382
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sfx2/source/view')
| -rw-r--r-- | sfx2/source/view/impviewframe.hxx | 2 | ||||
| -rw-r--r-- | sfx2/source/view/viewfrm.cxx | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/sfx2/source/view/impviewframe.hxx b/sfx2/source/view/impviewframe.hxx index ddcac6dee432..830035587965 100644 --- a/sfx2/source/view/impviewframe.hxx +++ b/sfx2/source/view/impviewframe.hxx @@ -35,7 +35,6 @@ struct SfxViewFrame_Impl OUString aActualURL; SfxFrame& rFrame; VclPtr<vcl::Window> pWindow; - VclPtr<vcl::Window> pFocusWin; sal_uInt16 nDocViewNo; SfxInterfaceId nCurViewId; bool bResizeInToOut:1; @@ -50,7 +49,6 @@ struct SfxViewFrame_Impl explicit SfxViewFrame_Impl(SfxFrame& i_rFrame) : rFrame(i_rFrame) , pWindow(nullptr) - , pFocusWin(nullptr) , nDocViewNo(0) , nCurViewId(0) , bResizeInToOut(false) diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx index b12c96a2d048..9b1d7b1fe507 100644 --- a/sfx2/source/view/viewfrm.cxx +++ b/sfx2/source/view/viewfrm.cxx @@ -1400,7 +1400,6 @@ void SfxViewFrame::Construct_Impl( SfxObjectShell *pObjSh ) { m_pImpl->bResizeInToOut = true; m_pImpl->bObjLocked = false; - m_pImpl->pFocusWin = nullptr; m_pImpl->nCurViewId = SFX_INTERFACE_NONE; m_pImpl->bReloading = false; m_pImpl->bIsDowning = false; @@ -1484,7 +1483,6 @@ SfxViewFrame::~SfxViewFrame() KillDispatcher_Impl(); m_pImpl->pWindow.disposeAndClear(); - m_pImpl->pFocusWin.clear(); if ( GetFrame().GetCurrentViewFrame() == this ) GetFrame().SetCurrentViewFrame_Impl( nullptr ); |