diff options
| author | Henry Castro <hcastro@collabora.com> | 2020-09-23 10:59:44 -0400 |
|---|---|---|
| committer | Henry Castro <hcastro@collabora.com> | 2020-10-05 17:11:02 +0200 |
| commit | 96fa2f494560bcc90584a458438db688b7f0aa88 (patch) | |
| tree | a096c3faad0191ce3e6b25628bc3a808f19f95bc /sfx2/source | |
| parent | a52246c4079de02f927582b0e8a476e9edafbc99 (diff) | |
lok: sidebar: avoid deactivation when the sidebar is painting
When two views (SfxViewFrame) get activated and deactivated
frequently when one view grab the focus and lose focus (respectively),
in multiple user this is not true, both users have the view
active at the same time.
The patch removes the overhead when painting a sidebar window
to avoid unnecessary deactivation.
Change-Id: Ica5837c9f2eda5db1bee69ec2297e54c4845d467
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103263
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Henry Castro <hcastro@collabora.com>
(cherry picked from commit 0a8be32f6130a4b84cd3f9ca70f6109dd78bf434)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103441
Tested-by: Jenkins
Diffstat (limited to 'sfx2/source')
| -rw-r--r-- | sfx2/source/appl/app.cxx | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx index fbd45b3e49b3..16592e536f27 100644 --- a/sfx2/source/appl/app.cxx +++ b/sfx2/source/appl/app.cxx @@ -50,6 +50,7 @@ #include <sfx2/stbitem.hxx> #include <sfx2/dockwin.hxx> #include <shellimpl.hxx> +#include <comphelper/lok.hxx> #include <svtools/helpopt.hxx> #include <unotools/viewoptions.hxx> @@ -254,7 +255,9 @@ void SfxApplication::SetViewFrame_Impl( SfxViewFrame *pFrame ) { if ( bTaskActivate ) NotifyEvent( SfxViewEventHint( SfxEventHintId::DeactivateDoc, GlobalEventConfig::GetEventName(GlobalEventId::DEACTIVATEDOC), pOldFrame->GetObjectShell(), pOldFrame->GetFrame().GetController() ) ); - pOldFrame->DoDeactivate( bTaskActivate, pFrame ); + + if ( !comphelper::LibreOfficeKit::isDialogPainting() ) + pOldFrame->DoDeactivate( bTaskActivate, pFrame ); if( pOldFrame->GetProgress() ) pOldFrame->GetProgress()->Suspend(); |