diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-02 15:10:58 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-03 08:07:41 +0100 |
| commit | acdba3c2eee18ef0c079b7c41cd4165e06c956c7 (patch) | |
| tree | 18c6da7b7d46bf901b6dd4f7a5b280caa7f62280 /sfx2/source | |
| parent | f4bd9029ba7b500ebf99b7fa3d774de7fa029176 (diff) | |
loplugin:passstuffbyref more return improvements
slightly less restrictive check when calling functions
Change-Id: I35e268ac611797b1daa83777cda02288a635aa32
Reviewed-on: https://gerrit.libreoffice.org/47259
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sfx2/source')
| -rw-r--r-- | sfx2/source/sidebar/TabBar.cxx | 2 | ||||
| -rw-r--r-- | sfx2/source/view/classificationcontroller.cxx | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/sfx2/source/sidebar/TabBar.cxx b/sfx2/source/sidebar/TabBar.cxx index a18de4f77171..7a9ede9a1f4f 100644 --- a/sfx2/source/sidebar/TabBar.cxx +++ b/sfx2/source/sidebar/TabBar.cxx @@ -306,7 +306,7 @@ IMPL_LINK_NOARG(TabBar::Item, HandleClick, Button*, void) {} // workaround for #i123198# } -const ::rtl::OUString TabBar::GetDeckIdForIndex (const sal_Int32 nIndex) const +OUString const & TabBar::GetDeckIdForIndex (const sal_Int32 nIndex) const { if (nIndex<0 || static_cast<size_t>(nIndex)>=maItems.size()) throw RuntimeException(); diff --git a/sfx2/source/view/classificationcontroller.cxx b/sfx2/source/view/classificationcontroller.cxx index 81c4762c8403..9e726230326b 100644 --- a/sfx2/source/view/classificationcontroller.cxx +++ b/sfx2/source/view/classificationcontroller.cxx @@ -105,7 +105,7 @@ public: namespace { -OUString getCategoryType() +OUString const & getCategoryType() { return SfxClassificationHelper::policyTypeToString(SfxClassificationHelper::getPolicyType()); } |