loplugin:stringliteralvar look for assignments

to O[U]String from char array literals, we can convert the char literals
to O[U]StringLiteral and avoid a runtime allocation

Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>

1 files changed, 60 insertions, 60 deletions

diff --git a/sfx2/source/appl/appuno.cxx b/sfx2/source/appl/appuno.cxx
index 413dd7d41736..c02f164de836 100644
--- a/sfx2/source/appl/appuno.cxx
+++ b/sfx2/source/appl/appuno.cxx
@@ -95,66 +95,66 @@ SfxFormalArgument const aFormalArgs[] = {
 
 sal_uInt16 const nMediaArgsCount = SAL_N_ELEMENTS(aFormalArgs);
 
-char const sTemplateRegionName[] = "TemplateRegionName";
-char const sTemplateName[] = "TemplateName";
-char const sAsTemplate[] = "AsTemplate";
-char const sOpenNewView[] = "OpenNewView";
-char const sViewId[] = "ViewId";
-char const sPluginMode[] = "PluginMode";
-char const sReadOnly[] = "ReadOnly";
-char const sDdeReconnect[] = "DDEReconnect";
-char const sStartPresentation[] = "StartPresentation";
-char const sFrameName[] = "FrameName";
-char const sMediaType[] = "MediaType";
-char const sPostData[] = "PostData";
-char const sCharacterSet[] = "CharacterSet";
-char const sInputStream[] = "InputStream";
-char const sStream[] = "Stream";
-char const sOutputStream[] = "OutputStream";
-char const sHidden[] = "Hidden";
-char const sPreview[] = "Preview";
-char const sViewOnly[] = "ViewOnly";
-char const sDontEdit[] = "DontEdit";
-char const sSilent[] = "Silent";
-char const sJumpMark[] = "JumpMark";
-char const sSalvagedFile[] = "SalvagedFile";
-char const sStatusInd[] = "StatusIndicator";
-char const sModel[] = "Model";
-char const sFrame[] = "Frame";
-char const sViewData[] = "ViewData";
-char const sFilterData[] = "FilterData";
-char const sSelectionOnly[] = "SelectionOnly";
-char const sMacroExecMode[] = "MacroExecutionMode";
-char const sUpdateDocMode[] = "UpdateDocMode";
-char const sMinimized[] = "Minimized";
-char const sInteractionHdl[] = "InteractionHandler";
-char const sUCBContent[] = "UCBContent";
-char const sRepairPackage[] = "RepairPackage";
-char const sDocumentTitle[] = "DocumentTitle";
-char const sComponentData[] = "ComponentData";
-char const sComponentContext[] = "ComponentContext";
-char const sDocumentBaseURL[] = "DocumentBaseURL";
-char const sHierarchicalDocumentName[] = "HierarchicalDocumentName";
-char const sCopyStreamIfPossible[] = "CopyStreamIfPossible";
-char const sNoAutoSave[] = "NoAutoSave";
-char const sFolderName[] = "FolderName";
-char const sUseSystemDialog[] = "UseSystemDialog";
-char const sStandardDir[] = "StandardDir";
-char const sDenyList[] = "DenyList";
-char const sModifyPasswordInfo[] = "ModifyPasswordInfo";
-char const sSuggestedSaveAsDir[] = "SuggestedSaveAsDir";
-char const sSuggestedSaveAsName[] = "SuggestedSaveAsName";
-char const sEncryptionData[] = "EncryptionData";
-char const sFailOnWarning[] = "FailOnWarning";
-char const sDocumentService[] = "DocumentService";
-char const sFilterProvider[] = "FilterProvider";
-char const sImageFilter[] = "ImageFilter";
-char const sLockContentExtraction[] = "LockContentExtraction";
-char const sLockExport[] = "LockExport";
-char const sLockPrint[] = "LockPrint";
-char const sLockSave[] = "LockSave";
-char const sLockEditDoc[] = "LockEditDoc";
-char const sReplaceable[] = "Replaceable";
+constexpr OUStringLiteral sTemplateRegionName = u"TemplateRegionName";
+constexpr OUStringLiteral sTemplateName = u"TemplateName";
+constexpr OUStringLiteral sAsTemplate = u"AsTemplate";
+constexpr OUStringLiteral sOpenNewView = u"OpenNewView";
+constexpr OUStringLiteral sViewId = u"ViewId";
+constexpr OUStringLiteral sPluginMode = u"PluginMode";
+constexpr OUStringLiteral sReadOnly = u"ReadOnly";
+constexpr OUStringLiteral sDdeReconnect = u"DDEReconnect";
+constexpr OUStringLiteral sStartPresentation = u"StartPresentation";
+constexpr OUStringLiteral sFrameName = u"FrameName";
+constexpr OUStringLiteral sMediaType = u"MediaType";
+constexpr OUStringLiteral sPostData = u"PostData";
+constexpr OUStringLiteral sCharacterSet = u"CharacterSet";
+constexpr OUStringLiteral sInputStream = u"InputStream";
+constexpr OUStringLiteral sStream = u"Stream";
+constexpr OUStringLiteral sOutputStream = u"OutputStream";
+constexpr OUStringLiteral sHidden = u"Hidden";
+constexpr OUStringLiteral sPreview = u"Preview";
+constexpr OUStringLiteral sViewOnly = u"ViewOnly";
+constexpr OUStringLiteral sDontEdit = u"DontEdit";
+constexpr OUStringLiteral sSilent = u"Silent";
+constexpr OUStringLiteral sJumpMark = u"JumpMark";
+constexpr OUStringLiteral sSalvagedFile = u"SalvagedFile";
+constexpr OUStringLiteral sStatusInd = u"StatusIndicator";
+constexpr OUStringLiteral sModel = u"Model";
+constexpr OUStringLiteral sFrame = u"Frame";
+constexpr OUStringLiteral sViewData = u"ViewData";
+constexpr OUStringLiteral sFilterData = u"FilterData";
+constexpr OUStringLiteral sSelectionOnly = u"SelectionOnly";
+constexpr OUStringLiteral sMacroExecMode = u"MacroExecutionMode";
+constexpr OUStringLiteral sUpdateDocMode = u"UpdateDocMode";
+constexpr OUStringLiteral sMinimized = u"Minimized";
+constexpr OUStringLiteral sInteractionHdl = u"InteractionHandler";
+constexpr OUStringLiteral sUCBContent = u"UCBContent";
+constexpr OUStringLiteral sRepairPackage = u"RepairPackage";
+constexpr OUStringLiteral sDocumentTitle = u"DocumentTitle";
+constexpr OUStringLiteral sComponentData = u"ComponentData";
+constexpr OUStringLiteral sComponentContext = u"ComponentContext";
+constexpr OUStringLiteral sDocumentBaseURL = u"DocumentBaseURL";
+constexpr OUStringLiteral sHierarchicalDocumentName = u"HierarchicalDocumentName";
+constexpr OUStringLiteral sCopyStreamIfPossible = u"CopyStreamIfPossible";
+constexpr OUStringLiteral sNoAutoSave = u"NoAutoSave";
+constexpr OUStringLiteral sFolderName = u"FolderName";
+constexpr OUStringLiteral sUseSystemDialog = u"UseSystemDialog";
+constexpr OUStringLiteral sStandardDir = u"StandardDir";
+constexpr OUStringLiteral sDenyList = u"DenyList";
+constexpr OUStringLiteral sModifyPasswordInfo = u"ModifyPasswordInfo";
+constexpr OUStringLiteral sSuggestedSaveAsDir = u"SuggestedSaveAsDir";
+constexpr OUStringLiteral sSuggestedSaveAsName = u"SuggestedSaveAsName";
+constexpr OUStringLiteral sEncryptionData = u"EncryptionData";
+constexpr OUStringLiteral sFailOnWarning = u"FailOnWarning";
+constexpr OUStringLiteral sDocumentService = u"DocumentService";
+constexpr OUStringLiteral sFilterProvider = u"FilterProvider";
+constexpr OUStringLiteral sImageFilter = u"ImageFilter";
+constexpr OUStringLiteral sLockContentExtraction = u"LockContentExtraction";
+constexpr OUStringLiteral sLockExport = u"LockExport";
+constexpr OUStringLiteral sLockPrint = u"LockPrint";
+constexpr OUStringLiteral sLockSave = u"LockSave";
+constexpr OUStringLiteral sLockEditDoc = u"LockEditDoc";
+constexpr OUStringLiteral sReplaceable = u"Replaceable";
 
 static bool isMediaDescriptor( sal_uInt16 nSlotId )
 {