diff options
| author | Tor Lillqvist <tml@iki.fi> | 2013-04-02 00:45:34 +0300 |
|---|---|---|
| committer | Tor Lillqvist <tml@iki.fi> | 2013-04-02 00:55:56 +0300 |
| commit | 532dee5f3d0e9836559d296c93182343dbaf3ab8 (patch) | |
| tree | dcbccaa15953c8ed9f4a5e2fd452a7567817e7ca /sfx2/source | |
| parent | a9f03c1ad14890f2cd02ebfc1c2adfe9c2b55259 (diff) | |
Add comment about the ugly hardcoded resource ids
Change-Id: I54d04f97fe720d6a262a86b63126f328a7812018
Diffstat (limited to 'sfx2/source')
| -rw-r--r-- | sfx2/source/appl/workwin.cxx | 18 |
1 files changed, 15 insertions, 3 deletions
diff --git a/sfx2/source/appl/workwin.cxx b/sfx2/source/appl/workwin.cxx index 99da99d4e611..cce1d39d2ddc 100644 --- a/sfx2/source/appl/workwin.cxx +++ b/sfx2/source/appl/workwin.cxx @@ -65,9 +65,21 @@ struct ResIdToResName static const ResIdToResName pToolBarResToName[] = { - { 558, "fullscreenbar" }, - { 560, "standardbar", }, - { 18001, "formsnavigationbar" }, + // OMG! hardcoded numbers that have nice (?) symbolic names + // elsewhere. + { 558, "fullscreenbar" }, // This 558 for instance equals RID_FULLSCREENTOOLBOX (in + // value, and presumably also in semantics) from app.hrc in + // this very same directory, so why RID_FULLSCREENTOOLBOX + // can't be used I have no idea. + + { 560, "standardbar", }, // 560 is called RID_ENVTOOLBOX in app.hrc, still the same? + + { 18001, "formsnavigationbar" }, // Probably the rest are defined in .hrc files that are higher + // up in the dependency chain and/or later in the build order, + // and that is the (bad) reason why their symbolic names are + // not available? Would it really be so owful to move the .hrc + // files in question out from the modules where they now are? + { 18002, "formsfilterbar" }, { 18003, "formtextobjectbar" }, { 18004, "formcontrols" }, |