diff options
| author | Stephan Bergmann <stephan.bergmann@allotropia.de> | 2024-11-13 15:29:35 +0100 |
|---|---|---|
| committer | Stephan Bergmann <stephan.bergmann@allotropia.de> | 2024-11-14 12:49:22 +0100 |
| commit | 16e3b84d2e04cc3e976b59ca4cecd59ca1577cbc (patch) | |
| tree | fbc01b0799a8741117ca9326cb3430ee973ea31e /sfx2/source | |
| parent | ac2983bbfbc389b3c3a60b6dc31b96f6686f5233 (diff) | |
Improve loplugin:dyncastvisibility to check for non-inline key functions
This would have caught the issue discussed in
709b1f3ddb87303a2dec6155dbe0106369c151ed "Make sure VCLXPopupMenu has unique
RTTI". (The commit message talks about RTTI there, while what Clang actually
compared for an optimized implementation of a dynamic_cast to a final class is
vtable pointers, but the overall picture remains the same. Both RTTI and
vtables are emitted along the key function, and if that is missing or inline,
they are emitted for each dynamic library individually, and as internal symbols
on macOS.)
This commit also addresses all the issues found by the improved
loplugin:dyncastvisibility on Linux. See the newly added TODO in
compilerplugins/clang/dyncastvisibility.cxx and
86b86ac87ea0cc90249f156494c98c3c93e4f3fc "Give DocumentEventHolder (aka
EventHolder<DocumentEvent>) a key function" for an issue with key functions for
class template instantiations.
Change-Id: Ia19155efb1d23692c92b9c97ff17f18ae7a1f3ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/176576
Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de>
Tested-by: Jenkins
Diffstat (limited to 'sfx2/source')
| -rw-r--r-- | sfx2/source/appl/app.cxx | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/sfx2/source/appl/app.cxx b/sfx2/source/appl/app.cxx index 3000c06e4dd0..b2a932c16e67 100644 --- a/sfx2/source/appl/app.cxx +++ b/sfx2/source/appl/app.cxx @@ -60,6 +60,8 @@ using namespace ::com::sun::star; +SfxLinkItem::~SfxLinkItem() = default; + static SfxApplication* g_pSfxApplication = nullptr; #if HAVE_FEATURE_XMLHELP |