diff options
author | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 09:07:25 +0000 |
---|---|---|
committer | Caolán McNamara <caolanm@redhat.com> | 2015-01-29 23:42:26 +0000 |
commit | 309574394bd4ae3e9e10e5ff0d64bdd7bbbc8b83 (patch) | |
tree | f8b8cea0a81bc74ca34e8bda2d0dfce939b28ce0 /sfx2/source | |
parent | 20deac4903fc0697477e855feeff482b3da234f9 (diff) |
callcatcher: large newly detected unused methods post de-virtualization
i.e lots now able to be detected after...
commit b44cbb26efe1d0b0950b1e1613e131b506dc3876
Author: Noel Grandin <noel@peralex.com>
Date: Tue Jan 20 12:38:10 2015 +0200
new loplugin: change virtual methods to non-virtual
Where we can prove that the virtual method is never overriden.
In the case of pure-virtual methods, we remove the method entirely.
Sometimes this leads to entire methods and fields being
eliminated.
Change-Id: I605e2fa56f7186c3d3a764f3cd30f5cf7f881f9d
Diffstat (limited to 'sfx2/source')
-rw-r--r-- | sfx2/source/appl/appdde.cxx | 58 | ||||
-rw-r--r-- | sfx2/source/control/thumbnailviewacc.cxx | 13 | ||||
-rw-r--r-- | sfx2/source/control/thumbnailviewacc.hxx | 2 | ||||
-rw-r--r-- | sfx2/source/dialog/templdlg.cxx | 47 | ||||
-rw-r--r-- | sfx2/source/doc/objmisc.cxx | 10 | ||||
-rw-r--r-- | sfx2/source/view/viewfrm2.cxx | 5 | ||||
-rw-r--r-- | sfx2/source/view/viewsh.cxx | 13 |
7 files changed, 0 insertions, 148 deletions
diff --git a/sfx2/source/appl/appdde.cxx b/sfx2/source/appl/appdde.cxx index 7c0a5255256e..a1b7f8595a34 100644 --- a/sfx2/source/appl/appdde.cxx +++ b/sfx2/source/appl/appdde.cxx @@ -425,64 +425,6 @@ void SfxObjectShell::ReconnectDdeLinks(SfxObjectShell& rServer) } } -/* [Description] - - This method can be overridden by application developers, to receive - DDE-commands directed to the their SfxApplication subclass. - - The base implementation understands the API functionality of the - relevant SfxViewFrame, which is shown and the relevant SfxViewShell - and the relevant SfxApplication subclass in BASIC syntax. Return - values can not be transferred, unfortunately. -*/ -long SfxViewFrame::DdeExecute( const OUString& rCmd ) // Expressed in our BASIC-Syntax -{ - if ( GetObjectShell() ) - return GetObjectShell()->DdeExecute( rCmd ); - - return 0; -} - -/* [Description] - - This method can be overridden by application developers, to receive - DDE-data-requests directed to their SfxApplication subclass. - - The base implementation provides no data and returns false. -*/ -bool SfxViewFrame::DdeGetData( const OUString&, // the Item to be addressed - const OUString&, // in: Format - ::com::sun::star::uno::Any& )// out: requested data -{ - return false; -} - -/* [Description] - - This method can be overridden by application developers, to receive - DDE-data directed to their SfxApplication subclass. - - The base implementation is not receiving any data and returns false. -*/ -bool SfxViewFrame::DdeSetData( const OUString&, // the Item to be addressed - const OUString&, // in: Format - const ::com::sun::star::uno::Any& )// out: requested data -{ - return false; -} - -/* [Description] - - This method can be overridden by application developers, to establish - a DDE-hotlink to their SfxApplication subclass. - - The base implementation is not generate a link and returns 0. -*/ -::sfx2::SvLinkSource* SfxViewFrame::DdeCreateLinkSource( const OUString& )// the Item to be addressed -{ - return 0; -} - bool SfxApplication::InitializeDde() { int nError = 0; diff --git a/sfx2/source/control/thumbnailviewacc.cxx b/sfx2/source/control/thumbnailviewacc.cxx index 28de61f3e989..4d0886e8de2f 100644 --- a/sfx2/source/control/thumbnailviewacc.cxx +++ b/sfx2/source/control/thumbnailviewacc.cxx @@ -415,13 +415,6 @@ void SAL_CALL ThumbnailViewAcc::grabFocus() mpParent->GrabFocus(); } -uno::Any SAL_CALL ThumbnailViewAcc::getAccessibleKeyBinding() - throw (uno::RuntimeException) -{ - ThrowIfDisposed(); - return uno::Any(); -} - sal_Int32 SAL_CALL ThumbnailViewAcc::getForeground( ) throw (uno::RuntimeException, std::exception) { @@ -957,12 +950,6 @@ void SAL_CALL ThumbnailViewItemAcc::grabFocus() // nothing to do } -uno::Any SAL_CALL ThumbnailViewItemAcc::getAccessibleKeyBinding() - throw (uno::RuntimeException) -{ - return uno::Any(); -} - sal_Int32 SAL_CALL ThumbnailViewItemAcc::getForeground( ) throw (uno::RuntimeException, std::exception) { diff --git a/sfx2/source/control/thumbnailviewacc.hxx b/sfx2/source/control/thumbnailviewacc.hxx index 737b0c09c4bc..3eae0c037e66 100644 --- a/sfx2/source/control/thumbnailviewacc.hxx +++ b/sfx2/source/control/thumbnailviewacc.hxx @@ -111,7 +111,6 @@ public: virtual ::com::sun::star::awt::Point SAL_CALL getLocationOnScreen( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; virtual ::com::sun::star::awt::Size SAL_CALL getSize( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; virtual void SAL_CALL grabFocus( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; - ::com::sun::star::uno::Any SAL_CALL getAccessibleKeyBinding( ) throw (::com::sun::star::uno::RuntimeException); virtual sal_Int32 SAL_CALL getForeground( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; virtual sal_Int32 SAL_CALL getBackground( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; @@ -226,7 +225,6 @@ public: virtual ::com::sun::star::awt::Point SAL_CALL getLocationOnScreen( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; virtual ::com::sun::star::awt::Size SAL_CALL getSize( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; virtual void SAL_CALL grabFocus( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; - ::com::sun::star::uno::Any SAL_CALL getAccessibleKeyBinding( ) throw (::com::sun::star::uno::RuntimeException); virtual sal_Int32 SAL_CALL getForeground( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; virtual sal_Int32 SAL_CALL getBackground( ) throw (::com::sun::star::uno::RuntimeException, std::exception) SAL_OVERRIDE; diff --git a/sfx2/source/dialog/templdlg.cxx b/sfx2/source/dialog/templdlg.cxx index 3650edcf77cd..22d5020ab05d 100644 --- a/sfx2/source/dialog/templdlg.cxx +++ b/sfx2/source/dialog/templdlg.cxx @@ -279,17 +279,11 @@ SfxTemplatePanelControl::SfxTemplatePanelControl ( SetStyle(GetStyle() & ~WB_DOCKABLE); } - - - SfxTemplatePanelControl::~SfxTemplatePanelControl (void) { delete pImpl; } - - - void SfxTemplatePanelControl::DataChanged( const DataChangedEvent& _rDCEvt ) { if ( ( DataChangedEventType::SETTINGS == _rDCEvt.GetType() ) && @@ -302,17 +296,6 @@ void SfxTemplatePanelControl::DataChanged( const DataChangedEvent& _rDCEvt ) DockingWindow::DataChanged( _rDCEvt ); } - - - -void SfxTemplatePanelControl::Update() -{ - pImpl->Update(); -} - - - - void SfxTemplatePanelControl::Resize() { if(pImpl) @@ -320,39 +303,11 @@ void SfxTemplatePanelControl::Resize() DockingWindow::Resize(); } - void SfxTemplatePanelControl::FreeResource (void) { DockingWindow::FreeResource(); } - -SfxChildAlignment SfxTemplatePanelControl::CheckAlignment(SfxChildAlignment eActAlign,SfxChildAlignment eAlign) -{ - switch (eAlign) - { - case SFX_ALIGN_TOP: - case SFX_ALIGN_HIGHESTTOP: - case SFX_ALIGN_LOWESTTOP: - case SFX_ALIGN_BOTTOM: - case SFX_ALIGN_LOWESTBOTTOM: - case SFX_ALIGN_HIGHESTBOTTOM: - return eActAlign; - - case SFX_ALIGN_LEFT: - case SFX_ALIGN_RIGHT: - case SFX_ALIGN_FIRSTLEFT: - case SFX_ALIGN_LASTLEFT: - case SFX_ALIGN_FIRSTRIGHT: - case SFX_ALIGN_LASTRIGHT: - return eAlign; - - default: - return eAlign; - } -} - - void SfxTemplatePanelControl::StateChanged( StateChangedType nStateChange ) { if ( nStateChange == StateChangedType::INITSHOW ) @@ -372,8 +327,6 @@ void SfxTemplatePanelControl::StateChanged( StateChangedType nStateChange ) DockingWindow::StateChanged( nStateChange ); } - - void StyleTreeListBox_Impl::MakeExpanded_Impl(ExpandedEntries_t& rEntries) const { SvTreeListEntry *pEntry; diff --git a/sfx2/source/doc/objmisc.cxx b/sfx2/source/doc/objmisc.cxx index d24cb6b34d30..4c8746f27f04 100644 --- a/sfx2/source/doc/objmisc.cxx +++ b/sfx2/source/doc/objmisc.cxx @@ -1594,12 +1594,6 @@ ErrCode SfxObjectShell::CallXScript( const OUString& rScriptURL, return CallXScript( GetModel(), rScriptURL, aParams, aRet, aOutParamIndex, aOutParam, bRaiseError, pCaller ); } - -SfxFrame* SfxObjectShell::GetSmartSelf( SfxFrame* pSelf, SfxMedium& /*rMedium*/ ) -{ - return pSelf; -} - SfxObjectShellFlags SfxObjectShell::GetFlags() const { if( pImp->eFlags == SFXOBJECTSHELL_UNDEFINED ) @@ -1823,10 +1817,6 @@ bool SfxObjectShell::IsUIActive() return pFrame && pFrame->GetFrame().IsInPlace() && pFrame->GetFrame().GetWorkWindow_Impl()->IsVisible_Impl(); } -void SfxObjectShell::UIActivate( bool ) -{ -} - void SfxObjectShell::InPlaceActivate( bool ) { } diff --git a/sfx2/source/view/viewfrm2.cxx b/sfx2/source/view/viewfrm2.cxx index cad0bcda3814..ff8f3e9f2698 100644 --- a/sfx2/source/view/viewfrm2.cxx +++ b/sfx2/source/view/viewfrm2.cxx @@ -385,11 +385,6 @@ void SfxViewFrame::INetState_Impl( SfxItemSet &rItemSet ) rItemSet.DisableItem( SID_CREATELINK ); } -void SfxViewFrame::SetZoomFactor( const Fraction &rZoomX, const Fraction &rZoomY ) -{ - GetViewShell()->SetZoomFactor( rZoomX, rZoomY ); -} - void SfxViewFrame::Activate( bool bMDI ) { DBG_ASSERT(GetViewShell(), "No Shell"); diff --git a/sfx2/source/view/viewsh.cxx b/sfx2/source/view/viewsh.cxx index cf0457b88e30..8d1fe4446b62 100644 --- a/sfx2/source/view/viewsh.cxx +++ b/sfx2/source/view/viewsh.cxx @@ -1883,28 +1883,15 @@ void SfxViewShell::SetMargin( const Size& rSize ) } } - - void SfxViewShell::MarginChanged() { } - - bool SfxViewShell::IsShowView_Impl() const { return pImp->m_bIsShowView; } - - -SfxFrame* SfxViewShell::GetSmartSelf( SfxFrame* pSelf, SfxMedium& /*rMedium*/ ) -{ - return pSelf; -} - - - void SfxViewShell::JumpToMark( const OUString& rMark ) { SfxStringItem aMarkItem( SID_JUMPTOMARK, rMark ); |