diff options
author | Skyler Grey <skyler.grey@collabora.com> | 2024-07-30 10:17:31 +0000 |
---|---|---|
committer | Miklos Vajna <vmiklos@collabora.com> | 2024-08-28 09:41:18 +0200 |
commit | 4e04e96334a841865914c1629202912e343c4cb2 (patch) | |
tree | fdffdf77ed92787afd66259cc5a670c81d374afc /sfx2/source | |
parent | 07fda011173917aaad75678b86e2b0570e004f93 (diff) |
fix(invert): Avoid spurious LOK invalidations
Using the same mechanism as with theme changes, we can avoid LOK getting
invalidations if we have an invert-background change that doesn't apply.
The trouble is that this method of inverting the background causes *lots
of* properties to change, so there's no single "If we inverted the
background" to check...
To get there, I've checked if all of the following are true
- We didn't change the color scheme
- We didn't have any new colors after this change
- All of the properties we were changing should have been within this
color scheme
While they don't necessarily mean "there was a background inversion",
they do mean "something changed in your theme but no action is needed
from you" - which should only be a background inversion - and if we
added anything else that could fit in that category, it should also
avoid LOK invalidations
Change-Id: Idb680d5241db7879d9be834268ab616848c1f165
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/172505
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
Diffstat (limited to 'sfx2/source')
-rw-r--r-- | sfx2/source/appl/appserv.cxx | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/sfx2/source/appl/appserv.cxx b/sfx2/source/appl/appserv.cxx index 603b1b90648f..5d94b1d5786f 100644 --- a/sfx2/source/appl/appserv.cxx +++ b/sfx2/source/appl/appserv.cxx @@ -754,7 +754,6 @@ void SfxApplication::MiscExec_Impl( SfxRequest& rReq ) } svtools::ColorConfigValue aValue; - aValue.bIsVisible = true; if(aNewTheme == "Dark") aValue.nColor = aDefDarkColor; |