diff options
author | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-16 15:22:48 +0200 |
---|---|---|
committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2018-01-28 07:32:20 +0100 |
commit | 8ff90e5d901772e0c92356bf7c6a90caaac7964e (patch) | |
tree | ca593f032e28c03eb452f6bf3c1b51b43b530a78 /sfx2/source | |
parent | b2897ae7e15d69e25bc608f073e77a5a7aabd9b3 (diff) |
loplugin:useuniqueptr in SfxRequest
Change-Id: Id2b2a1ac9803b0caa2d28163160d85be5253dd9e
Reviewed-on: https://gerrit.libreoffice.org/48699
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sfx2/source')
-rw-r--r-- | sfx2/source/control/request.cxx | 21 |
1 files changed, 10 insertions, 11 deletions
diff --git a/sfx2/source/control/request.cxx b/sfx2/source/control/request.cxx index d7e6e6af1346..086aa45ec38c 100644 --- a/sfx2/source/control/request.cxx +++ b/sfx2/source/control/request.cxx @@ -123,7 +123,7 @@ SfxRequest::~SfxRequest() pImpl->Record( uno::Sequence < beans::PropertyValue >() ); // Clear object - delete pArgs; + pArgs.reset(); if ( pImpl->pRetVal ) DeleteItemOnIdle(pImpl->pRetVal); } @@ -408,8 +408,7 @@ void SfxRequest::Record_Impl void SfxRequest::SetArgs( const SfxAllItemSet& rArgs ) { - delete pArgs; - pArgs = new SfxAllItemSet(rArgs); + pArgs.reset(new SfxAllItemSet(rArgs)); pImpl->SetPool( pArgs->GetPool() ); } @@ -417,7 +416,7 @@ void SfxRequest::SetArgs( const SfxAllItemSet& rArgs ) void SfxRequest::AppendItem(const SfxPoolItem &rItem) { if(!pArgs) - pArgs = new SfxAllItemSet(*pImpl->pPool); + pArgs.reset( new SfxAllItemSet(*pImpl->pPool) ); pArgs->Put(rItem, rItem.Which()); } @@ -428,7 +427,7 @@ void SfxRequest::RemoveItem( sal_uInt16 nID ) { pArgs->ClearItem(nID); if ( !pArgs->Count() ) - DELETEZ(pArgs); + pArgs.reset(); } } @@ -480,7 +479,7 @@ void SfxRequest::Done // Keep items if possible, so they can be queried by StarDraw. if ( !pArgs ) { - pArgs = new SfxAllItemSet( rSet ); + pArgs.reset( new SfxAllItemSet( rSet ) ); pImpl->SetPool( pArgs->GetPool() ); } else @@ -500,15 +499,15 @@ void SfxRequest::Done void SfxRequest::Done( bool bRelease ) // [<SfxRequest::Done(SfxItemSet&)>] { - Done_Impl( pArgs ); + Done_Impl( pArgs.get() ); if( bRelease ) - DELETEZ( pArgs ); + pArgs.reset(); } void SfxRequest::ForgetAllArgs() { - DELETEZ( pArgs ); + pArgs.reset(); pImpl->pInternalArgs.reset(); } @@ -530,7 +529,7 @@ void SfxRequest::Cancel() { pImpl->bCancelled = true; pImpl->SetPool( nullptr ); - DELETEZ( pArgs ); + pArgs.reset(); } @@ -757,7 +756,7 @@ bool SfxRequest::AllowsRecording() const void SfxRequest::ReleaseArgs() { - DELETEZ( pArgs ); + pArgs.reset(); pImpl->pInternalArgs.reset(); } |