loplugin:unuseddefaultparam in sfx2

and fix an issue with calls to templated methods in the plugin

Change-Id: I9c9537a0690ff671286c007846d5f4cfb7d2982b

4 files changed, 9 insertions, 15 deletions

diff --git a/sfx2/source/appl/childwin.cxx b/sfx2/source/appl/childwin.cxx
index 1e1780e6ecf4..a616833dfb14 100644
--- a/sfx2/source/appl/childwin.cxx
+++ b/sfx2/source/appl/childwin.cxx
@@ -579,8 +579,7 @@ bool SfxChildWinInfo::GetExtraData_Impl
 (
     SfxChildAlignment   *pAlign,
     SfxChildAlignment   *pLastAlign,
-    Size                *pSize,
-    sal_uInt16          *pLine
+    Size                *pSize
 )   const
 {
     // invalid?
@@ -631,8 +630,6 @@ bool SfxChildWinInfo::GetExtraData_Impl
     {
         if ( pSize )
             *pSize = aChildSize;
-        if ( pLine )
-            *pLine = (sal_uInt16) aChildPos.X();
         return true;
     }
     return false;
diff --git a/sfx2/source/bastyp/fltfnc.cxx b/sfx2/source/bastyp/fltfnc.cxx
index b908d7ebd6c9..3e2837cb9335 100644
--- a/sfx2/source/bastyp/fltfnc.cxx
+++ b/sfx2/source/bastyp/fltfnc.cxx
@@ -374,8 +374,7 @@ const SfxFilter* SfxFilterMatcher::GetAnyFilter( SfxFilterFlags nMust, SfxFilter
 
 sal_uInt32  SfxFilterMatcher::GuessFilterIgnoringContent(
     SfxMedium& rMedium,
-    const SfxFilter**ppFilter,
-    SfxFilterFlags nMust ) const
+    const SfxFilter**ppFilter ) const
 {
     uno::Reference<document::XTypeDetection> xDetection(
         comphelper::getProcessServiceFactory()->createInstance("com.sun.star.document.TypeDetection"), uno::UNO_QUERY);
@@ -394,7 +393,7 @@ sal_uInt32  SfxFilterMatcher::GuessFilterIgnoringContent(
     {
         // make sure filter list is initialized
         m_rImpl.InitForIterating();
-        *ppFilter = GetFilter4EA( sTypeName, nMust );
+        *ppFilter = GetFilter4EA( sTypeName );
     }
 
     return *ppFilter ? ERRCODE_NONE : ERRCODE_ABORT;
diff --git a/sfx2/source/bastyp/progress.cxx b/sfx2/source/bastyp/progress.cxx
index 5d3700abb547..618590ee3509 100644
--- a/sfx2/source/bastyp/progress.cxx
+++ b/sfx2/source/bastyp/progress.cxx
@@ -215,13 +215,12 @@ void SfxProgress::Stop()
 bool SfxProgress::SetStateText
 (
     sal_uLong       nNewVal,     /* New value for the progress-bar */
-    const OUString& rNewVal,     /* Status as Text */
-    sal_uLong       nNewRange    /* new maximum value, 0 for retaining the old */
+    const OUString& rNewVal     /* Status as Text */
 )
 
 {
     pImp->aStateText = rNewVal;
-    return SetState( nNewVal, nNewRange );
+    return SetState( nNewVal );
 }
 
 bool SfxProgress::SetState
diff --git a/sfx2/source/dialog/tabdlg.cxx b/sfx2/source/dialog/tabdlg.cxx
index 106b93d04c65..1780f84de9c2 100644
--- a/sfx2/source/dialog/tabdlg.cxx
+++ b/sfx2/source/dialog/tabdlg.cxx
@@ -520,13 +520,12 @@ void SfxTabDialog::StartExecuteModal( const Link<Dialog&,void>& rEndDialogHdl )
 }
 
 
-void SfxTabDialog::Start( bool bShow )
+void SfxTabDialog::Start()
 {
     pImpl->bModal = false;
     Start_Impl();
 
-    if ( bShow )
-        Show();
+    Show();
 
     if ( IsVisible() && ( !HasChildPathFocus() || HasFocus() ) )
         GrabFocusToFirstControl();
@@ -575,9 +574,9 @@ void SfxTabDialog::Start_Impl()
     ActivatePageHdl( m_pTabCtrl );
 }
 
-void SfxTabDialog::AddTabPage( sal_uInt16 nId, const OUString &rRiderText, bool bItemsOnDemand )
+void SfxTabDialog::AddTabPage( sal_uInt16 nId, const OUString &rRiderText )
 {
-    AddTabPage( nId, rRiderText, nullptr, nullptr, bItemsOnDemand );
+    AddTabPage( nId, rRiderText, nullptr, nullptr );
 }
 
 /*