diff options
| author | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-05 08:34:22 +0200 |
|---|---|---|
| committer | Noel Grandin <noel.grandin@collabora.co.uk> | 2017-06-05 09:22:51 +0200 |
| commit | 17a2c9e8e2361de27013a25e51f3a3ca729f1b31 (patch) | |
| tree | 1c89bc104e5630fb71ff0a5b12c464ca2aceebc3 /sfx2 | |
| parent | 8fa4b0429b514c0d696ebfc2e47418292d7ec367 (diff) | |
clang-tidy performance-unnecessary-value-param
Change-Id: I6ed8c54c7c45931d91709cc818f2483c70197192
Reviewed-on: https://gerrit.libreoffice.org/38400
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Diffstat (limited to 'sfx2')
| -rw-r--r-- | sfx2/inc/uitest/sfx_uiobject.hxx | 2 | ||||
| -rw-r--r-- | sfx2/source/doc/docfile.cxx | 5 | ||||
| -rw-r--r-- | sfx2/source/notebookbar/DropdownBox.cxx | 2 | ||||
| -rw-r--r-- | sfx2/source/uitest/sfx_uiobject.cxx | 2 | ||||
| -rw-r--r-- | sfx2/source/view/viewfrm.cxx | 2 |
5 files changed, 7 insertions, 6 deletions
diff --git a/sfx2/inc/uitest/sfx_uiobject.hxx b/sfx2/inc/uitest/sfx_uiobject.hxx index 2feb03135236..b240a2745aa3 100644 --- a/sfx2/inc/uitest/sfx_uiobject.hxx +++ b/sfx2/inc/uitest/sfx_uiobject.hxx @@ -20,7 +20,7 @@ private: public: - SfxTabDialogUIObject(VclPtr<SfxTabDialog> xTabDialog); + SfxTabDialogUIObject(const VclPtr<SfxTabDialog>& xTabDialog); virtual ~SfxTabDialogUIObject() override; diff --git a/sfx2/source/doc/docfile.cxx b/sfx2/source/doc/docfile.cxx index 01108b65f849..30d7eb19b0a7 100644 --- a/sfx2/source/doc/docfile.cxx +++ b/sfx2/source/doc/docfile.cxx @@ -74,6 +74,7 @@ #include <framework/interaction.hxx> #include <unotools/streamhelper.hxx> #include <unotools/localedatawrapper.hxx> +#include <utility> #include <vcl/msgbox.hxx> #include <svl/stritem.hxx> #include <svl/eitem.hxx> @@ -2906,7 +2907,7 @@ SfxMedium::SfxMedium(const OUString &rName, StreamMode nOpenMode, std::shared_pt pImpl(new SfxMedium_Impl) { pImpl->m_pSet = pInSet; - pImpl->m_pFilter = pFilter; + pImpl->m_pFilter = std::move(pFilter); pImpl->m_aLogicName = rName; pImpl->m_nStorOpenMode = nOpenMode; Init_Impl(); @@ -2920,7 +2921,7 @@ SfxMedium::SfxMedium(const OUString &rName, const OUString &rReferer, StreamMode if (s->GetItem(SID_REFERER) == nullptr) { s->Put(SfxStringItem(SID_REFERER, rReferer)); } - pImpl->m_pFilter = pFilter; + pImpl->m_pFilter = std::move(pFilter); pImpl->m_aLogicName = rName; pImpl->m_nStorOpenMode = nOpenMode; Init_Impl(); diff --git a/sfx2/source/notebookbar/DropdownBox.cxx b/sfx2/source/notebookbar/DropdownBox.cxx index 981a220b0959..aba34a36ab72 100644 --- a/sfx2/source/notebookbar/DropdownBox.cxx +++ b/sfx2/source/notebookbar/DropdownBox.cxx @@ -37,7 +37,7 @@ private: ScopedVclPtr<DropdownBox> m_pParent; public: - explicit Popup(VclPtr<DropdownBox> pParent) + explicit Popup(const VclPtr<DropdownBox>& pParent) : FloatingWindow(pParent, "Popup", "sfx/ui/notebookbarpopup.ui") , m_pParent(pParent) { diff --git a/sfx2/source/uitest/sfx_uiobject.cxx b/sfx2/source/uitest/sfx_uiobject.cxx index 062910287adc..cdc7698fdabe 100644 --- a/sfx2/source/uitest/sfx_uiobject.cxx +++ b/sfx2/source/uitest/sfx_uiobject.cxx @@ -12,7 +12,7 @@ #include <sfx2/tabdlg.hxx> -SfxTabDialogUIObject::SfxTabDialogUIObject(VclPtr<SfxTabDialog> xTabDialog): +SfxTabDialogUIObject::SfxTabDialogUIObject(const VclPtr<SfxTabDialog>& xTabDialog): WindowUIObject(xTabDialog), mxTabDialog(xTabDialog) { diff --git a/sfx2/source/view/viewfrm.cxx b/sfx2/source/view/viewfrm.cxx index 0b41dd8ef095..de0cacabdba3 100644 --- a/sfx2/source/view/viewfrm.cxx +++ b/sfx2/source/view/viewfrm.cxx @@ -187,7 +187,7 @@ void SfxEditDocumentDialog::dispose() } /// Is this read-only object shell opened via .uno:SignPDF? -static bool IsSignPDF(SfxObjectShellRef xObjSh) +static bool IsSignPDF(const SfxObjectShellRef& xObjSh) { if (!xObjSh.is()) return false; |